TripList 페이지 구현 #51
Merged
TripList 페이지 구현 #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dladncks1217
commented
Jul 17, 2023
| width: `calc((100vw - 196px) / 5)`, | ||
| alignSelf: 'start', | ||
| margin: '0', | ||
| padding: '0', |
There was a problem hiding this comment.
전 별로 상관없긴한데 string으로 통일하는건 좀 별로려나요?🤔
| '-ms-overflow-style': 'none', | ||
| scrollbarWidth: 'none', | ||
| '& > span': { | ||
| marginRight: Theme.spacer.spacing2, |
There was a problem hiding this comment.
'& > span' 내부 속성들도 위 속성들 내부로 순서가 적용되는거였나요..?
'& > span' 같은건 css순서 별개로 밑에 몰아두는게 보는데 좋을 것 같은데 어떤가요?🤔
+ 스토리북 코드는 내일까지 작성하겠습니다~ |
ashleysyheo
reviewed
Jul 17, 2023
ashleysyheo
reviewed
Jul 17, 2023
dladncks1217
force-pushed
the
feature/#36
branch
from
86a6388
to
88b6a17
Compare
ashleysyheo
approved these changes
Jul 18, 2023
Dahyeeee
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Summary
트립 목록 화면
튜토리얼 모달 화면
🙋🏻 More
튜토리얼 모달
튜토리얼 모달에 대해, 존재하는 trip이 없을 경우 띄워주도록 우선 설정했습니다.
그렇다보니 현재 msw 모킹에 대해서 trip을 0개 반환하는 msw 핸들러와 trip들을 반환하는 핸들러로 나뉘어있습니다. 요청부분만 조금 다르게 해서 테스트할 수 있지 않을까 싶습니다.
close #36