Shared Status 이동 #639
Merged
Shared Status 이동 #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: hgo641 <hgo641@gmail.com>
📝 Jacoco Test Coverage
|
jjongwa
approved these changes
Sep 27, 2023
Comment on lines
147
to
155
| if (this.sharedStatus.equals(SharedStatusType.SHARED)) { | ||
| return Optional.empty(); | ||
| } | ||
| return Optional.of(sharedTrip.getSharedCode()); | ||
| } | ||
|
|
||
| public Boolean isShared() { | ||
| return this.sharedStatus.equals(SharedStatusType.SHARED); | ||
| } |
There was a problem hiding this comment.
아래에 만든 isShared()를 if문에 넣어도 될 듯 합니다.!
There was a problem hiding this comment.
사실 넣었었는데 소나린트가 저렇게 하라고 추천해주더라구요? 깔끔하게 isShared 갈까요?!
There was a problem hiding this comment.
진짜 충격적 삼보일배하고 가겠습니다 라온
Comment on lines
+1
to
+10
| ALTER TABLE trip ADD COLUMN shared_status ENUM ('SHARED','UNSHARED'); | ||
| UPDATE trip SET shared_status = 'UNSHARED'; | ||
| ALTER TABLE trip MODIFY COLUMN shared_status ENUM ('SHARED','UNSHARED') NOT NULL; | ||
|
|
||
| CREATE TABLE copy_shared_trip AS SELECT * FROM shared_trip; | ||
|
|
||
| UPDATE trip INNER JOIN shared_trip ON trip.id = shared_trip.trip_id | ||
| SET trip.shared_status = shared_trip.shared_status; | ||
|
|
||
| ALTER TABLE shared_trip DROP COLUMN shared_status; |
hgo641
approved these changes
Sep 27, 2023
jjongwa
pushed a commit
that referenced
this pull request
Oct 8, 2023
* chore: shared_status 이동 쿼리 작성 Co-authored-by: hgo641 <hgo641@gmail.com> * refactor: shared_status 이동에 따른 프로덕션 코드 수정 * refactor: boolean primitive 타입으로 변경 * fix: if 조건 수정 --------- Co-authored-by: hgo641 <hgo641@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Summary
#638
🙋🏻 More