UX개선 : 사진 업로드 시간이 길어질 때, 사용자가 이미지 업로드 완료 여부를 파악하기 힘든 문제 개선 #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dahyeeee
approved these changes
Oct 6, 2023
| @@ -112,5 +113,5 @@ export const useMultipleImageUpload = ({ | |||
| [onSuccess] | |||
| ); | |||
|
|
|||
| return { uploadedImageUrls, handleImageUpload, handleImageRemoval }; | |||
| return { isLoadingMutation, uploadedImageUrls, handleImageUpload, handleImageRemoval }; | |||
jjongwa
pushed a commit
that referenced
this pull request
Oct 8, 2023
* feature: 이미지 업로드 시 버튼 조건부 disable기능 추가 * chore: 컨벤션 준수를 위한 코드 수정 * refactor: isImageUploading상태 네이밍 수정 * feat: 프로필 사진 업로드 시 버튼 disabled 기능 추가 * chore: 불필요한 storybook파일 제거
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Summary
이제 이미지 업로드중인 상태이면 button disabled됩니다.
close #666