커뮤니티 전체&추천 여행 목록 조회 쿼리 개선 #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
oh test.. |
📝 Jacoco Test Coverage
|
mcodnjs
commented
Oct 13, 2023
Comment on lines
-249
to
+253
| verify(itemRepository).delete(any()); | ||
| verify(itemRepository).deleteById(any()); |
There was a problem hiding this comment.
여기 건들지도 않았는데 테스트 터짐! 이게 말.이.됩.니.까?
근데 이전 PR에선 안터졌음. 근데 터지는게 맞긴함
왜 안터졌지 ..? 뭔가 놓치고 있나 .. ? 근데 아무리 봐도 잘 모르겠다 ~
쨌든 테스트 터진 문제는 아래와 같습니다.
ExpenseRepository 참조하는데 모킹이 안되어있었고,
delete() -> deleteById()로 로직 바뀌었는데 verify 검증 부분은 안바꿔줘서 발생한 문제
LJW25
approved these changes
Oct 13, 2023
jjongwa
pushed a commit
that referenced
this pull request
Oct 19, 2023
* feat: member와 sharedTrip fetch join으로 쿼리 * feat: tripIds에 해당하는 List<City> 가져오도록 쿼리 * feat: tripIds에 해당하는 Like 정보 가져오도록 쿼리 * feat: 추천 목록 조회에도 적용 * feat: recommend 쿼리에서 sharedTrip fetch join으로 쿼리 * refactor: dto 네이밍 및 패키지 변경 * style: 쿼리 포맷 수정 * refactor: 일급컬렉션을 사용하여 맵 변환 및 관련 변수명 수정 * test: ItemServiceTest delete 메서드 수정
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Summary
4(=1+3)개의 쿼리는 아래와 같습니다!
@Auth로 인한 리프레시 토큰 검사🙋🏻 More