-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DB Replication 적용 #724
Merged
Merged
DB Replication 적용 #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
📝 Jacoco Test Coverage
|
LJW25
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
트랜잭션의 마법..드디어 탈출..
mcodnjs
force-pushed
the
chore/#712-db-replica
branch
from
October 19, 2023 01:50
98bcc79
to
daf8d5e
Compare
jjongwa
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Summary
으아아 이오 홍고와 함께한 길고 길었던 DB Replication 입니다.
문제가 끝난 줄 알았지만 아직 사소한 버그들이 있습니다.
우선 저희가 겪었던 문제는 p6spy로 인한 문제였고, 관련하여서는 조금 더 자세히 정리해서 업로드 하겠습니다!
현재 남은 문제로,
DB Replication을 위해 프록시 객체를 사용하면서 쿼리 카운터에 x3의 쿼리 개수를 증가시키는 마법이 발생하고 있습니다.
관련해서는 조금 더 찾아봐야 알겠지만, 이를 도입해서 나타나는 문제로 인지되고,
실제 쿼리 개수는 x3이 아닌 이전과 동일하게 나가는 것으로 판단하였습니다. (로그만 증가한 것, 아니면 말씀 부탁)
그리고, p6spy 같은 경우에는 운영 환경에서 성능 문제로 사용이 권장되지 않습니다.
(+ replication 적용을 위해서는 p6spy를 도입할 수 없습니다)
따라서, 현재 서브 모듈에서 default를 false로 해두고, local 및 test 환경에서만 사용 가능하도록 변경해놓았습니다.현재 정확한 동작을 위해 p6spy 의존성을 완전히 제거하였습니다 ..
이 부분도 확인 부탁드리겠습니다. . 감사합니다 ..
🙋🏻 More