Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FE] 반려동물 정보 등록, 수정 관련 리팩터링 #359

Closed
5 tasks done
HyeryongChoi opened this issue Aug 23, 2023 · 0 comments · Fixed by #360
Closed
5 tasks done

[FE] 반려동물 정보 등록, 수정 관련 리팩터링 #359

HyeryongChoi opened this issue Aug 23, 2023 · 0 comments · Fixed by #360
Assignees
@HyeryongChoi
Labels
🔨 Refactor
Milestone
방학 스프린트

Comments

@HyeryongChoi
Copy link
Collaborator

HyeryongChoi commented Aug 23, 2023 •
edited
Loading

🔨 Describe

반려동물 정보 등록, 수정 기능 구현 시 작성했던 코드를 리팩터링합니다.

✅ Tasks

  • PetProfileProvider -> PetAdditionProvider 함수명 변경
  • PetProfileOutletContextProps -> PetAdditionOutletContextProps 타입명 변경
  • 반려동물 등록 전체적인 구조 변경
  • 반려동물 수정 페이지 -> PetProfileEditionForm 컴포넌트 분리
  • usePetProfileEdition 훅 생성

🕖 예상 작업 소요 시간

4시간

🙋🏻 More

No response
@HyeryongChoi HyeryongChoi added this to the 방학 스프린트 milestone Aug 23, 2023
@HyeryongChoi HyeryongChoi self-assigned this Aug 23, 2023
HyeryongChoi added a commit that referenced this issue Aug 23, 2023
@HyeryongChoi
feat/#359: 반려동물 등록 Context 수정
311a5a9 
- PetProfileProvider > PetAdditionProvider로 변경
- PetProfileContext > PetAdditionContext로 변경
HyeryongChoi added a commit that referenced this issue Aug 23, 2023
@HyeryongChoi
refactor/#359: 반려동물 등록 인풋 핸들러 훅으로 분리
3d7b16c 
- usePetProfileAddition 생성
HyeryongChoi added a commit that referenced this issue Aug 23, 2023
@HyeryongChoi
refactor/#359: PetProfileEditionForm으로 분리
a051771
HyeryongChoi added a commit that referenced this issue Aug 23, 2023
@HyeryongChoi
refactor/#359: petProfile 관련 훅 파일 분리
b12fe9c 
- usePetProfileStep
- usePetProfileValidation
- usePetProfileAddition
HyeryongChoi added a commit that referenced this issue Aug 23, 2023
@HyeryongChoi
feat/#359: usePetProfileEdition 훅 추가
6d9ab3e
@HyeryongChoi HyeryongChoi mentioned this issue Aug 23, 2023
Merged
5 tasks
HyeryongChoi added a commit that referenced this issue Aug 31, 2023
@HyeryongChoi
refactor/#359: 에러메시지 상수로 분리
d3a55f6
HyeryongChoi added a commit that referenced this issue Aug 31, 2023
@HyeryongChoi
refactor/#359: useEasyNavigate 사용
8c3679d
HyeryongChoi added a commit that referenced this issue Aug 31, 2023
@HyeryongChoi
refactor/#359: 코드 간소화
1ab6445
HyeryongChoi added a commit that referenced this issue Sep 7, 2023
@HyeryongChoi
Merge branch 'develop' of https://github.com/woowacourse-teams/2023-z…
4cf7990 
…ipgo into refactor/#359
HyeryongChoi added a commit that referenced this issue Sep 7, 2023
@HyeryongChoi
refactor/#359: zipgoLocalStorage를 사용하도록 변경
850b074
HyeryongChoi added a commit that referenced this issue Sep 7, 2023
@HyeryongChoi
refactor/#359: 반려동물 수정 및 삭제 mutation 구조 수정
9ed8f2b 
- onSuccess, onError 라이프 사이클 활용
HyeryongChoi added a commit that referenced this issue Sep 7, 2023
@HyeryongChoi
refactor/#359: 변수명 수정
311fa20 
- postPetProfile -> postPet
- addPetProfile -> addPet
HyeryongChoi added a commit that referenced this issue Sep 11, 2023
@HyeryongChoi
refactor: 반려동물 정보 등록, 수정 관련 리팩터링 (#360)
2533c9e 
* feat/#359: 반려동물 등록 Context 수정

- PetProfileProvider > PetAdditionProvider로 변경
- PetProfileContext > PetAdditionContext로 변경

* refactor/#359: 반려동물 등록 인풋 핸들러 훅으로 분리

- usePetProfileAddition 생성

* refactor/#359: PetProfileEditionForm으로 분리

* refactor/#359: petProfile 관련 훅 파일 분리

- usePetProfileStep
- usePetProfileValidation
- usePetProfileAddition

* feat/#359: usePetProfileEdition 훅 추가

* refactor/#359: 에러메시지 상수로 분리

* refactor#359: PropsWithChildren 타입 사용

* refactor/#359: useEasyNavigate 사용

* refactor/#359: 코드 간소화

* refactor#359: onSuccess, onError 라이프사이클 활용

* refactor/#359: zipgoLocalStorage를 사용하도록 변경

* refactor/#359: 반려동물 수정 및 삭제 mutation 구조 수정

- onSuccess, onError 라이프 사이클 활용

* refactor/#359: 변수명 수정

- postPetProfile -> postPet
- addPetProfile -> addPet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HyeryongChoi HyeryongChoi

Labels
🔨 Refactor
Projects
2023-zipgo
Status: Done
Milestone
방학 스프린트
Development

Successfully merging a pull request may close this issue.

refactor: 반려동물 정보 등록, 수정 관련 리팩터링 woowacourse-teams/2023-zipgo
1 participant
@HyeryongChoi