Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] Health Check API 구현 & 404 에러 핸들러 추가 #95

Merged
merged 4 commits into from
Jul 24, 2024

Conversation

kelly6bf
Copy link
Contributor

연관된 이슈

구현한 기능

  • Health Check API
  • 404 Error Handler

상세 설명

서버 상태를 간단하게 점검할 수 있는 Health Check API와 404 응답을 내려줄 에러 핸들러를 추가하였다.

Copy link
Member

@koust6u koust6u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented Jul 24, 2024

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 8749217.

♻️ This comment has been updated with latest results.

public class CommonErrorController {

@ExceptionHandler
public ResponseEntity<ApiErrorResponse> handleNoResourceFoundException(NoResourceFoundException e) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기 파라미터에 final... 😅

@RestControllerAdvice
public class CommonErrorController {

@ExceptionHandler
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@ExceptionHandler
@ExceptionHandler(NoResourceFoundException.class)

페어룸 익셉션 핸들러에는 예외 클래스 명시해줬습니다

Copy link
Member

@reddevilmidzy reddevilmidzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kelly6bf kelly6bf merged commit ae3edeb into BE/dev Jul 24, 2024
3 checks passed
@kelly6bf kelly6bf deleted the #92-health_check_feat branch July 24, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants