Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] 4차 데모 전 수정사항 반영 #235

Closed
PgmJun opened this issue Aug 22, 2024 · 2 comments
Closed

[FIX] 4차 데모 전 수정사항 반영 #235

PgmJun opened this issue Aug 22, 2024 · 2 comments
Assignees
Labels
🍃 BE back end 🛠 fix 버그 ♻️ refactor 리팩토링
Milestone

Comments

@PgmJun
Copy link
Member

PgmJun commented Aug 22, 2024

Description 💭

4차 데모 전 QA를 통해 수정 사항을 발견 후 반영 한다.

Reference 🔎

@PgmJun PgmJun added 🛠 fix 버그 ♻️ refactor 리팩토링 🍃 BE back end labels Aug 22, 2024
@PgmJun PgmJun added this to the BE Sprint4 milestone Aug 22, 2024
@PgmJun PgmJun self-assigned this Aug 22, 2024
@PgmJun
Copy link
Member Author

PgmJun commented Aug 22, 2024

  • 처리 완료
@Transactional
    public void deleteRoomContents(Room room) {
        List<RoomContent> roomContents = roomContentRepository.findAllByRoom(room);
        roomContentRepository.deleteAllInBatch(roomContents);

        if (room.getTotalRound() != roomContents.size()) {
            log.error("방의 총 라운드와 방 컨텐츠 개수가 일치하지 않습니다. roomId: {}, totalRound: {}, roomContent 개수: {}",
                    room.getId(), room.getTotalRound(), roomContents.size());
        }
    }

해당 메서드의 log.error를 제거한다.

애초에 Room이 Start하기 전에는 RoomContent가 0이기 때문에
게임 도중이 아닌, Room에서 모든 멤버가 나가면 무조건 해당 에러 로그가 찍힌다.

@leegwichan
Copy link
Contributor

  • 처리 완료

RoomFacadefindRoomIdsBefore, deleteRoom 제거

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍃 BE back end 🛠 fix 버그 ♻️ refactor 리팩토링
Projects
Status: Done
Development

No branches or pull requests

2 participants