-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1단계 - 블랙잭 게임 실행] 카피(김상혁) 미션 제출합니다 #672
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: tkdgur0906 <tkdgur0906@naver.com>
Co-authored-by: tkdgur0906 <tkdgur0906@naver.com>
Co-authored-by: tkdgur0906 <tkdgur0906@naver.com>
Co-authored-by: tkdgur0906 <tkdgur0906@naver.com>
Co-authored-by: tkdgur0906 <tkdgur0906@naver.com>
Co-authored-by: tkdgur0906 <tkdgur0906@naver.com>
Co-authored-by: tkdgur0906 <tkdgur0906@naver.com>
Co-authored-by: tkdgur0906 <tkdgur0906@naver.com>
Co-authored-by: tkdgur0906 <tkdgur0906@naver.com>
Co-authored-by: tkdgur0906 <tkdgur0906@naver.com>
Co-authored-by: tkdgur0906 <tkdgur0906@naver.com>
Co-authored-by: tkdgur0906 <tkdgur0906@naver.com>
Co-authored-by: tkdgur0906 <tkdgur0906@naver.com>
Co-authored-by: tkdgur0906 <tkdgur0906@naver.com>
Co-authored-by: tkdgur0906 <tkdgur0906@naver.com>
Co-authored-by: tkdgur0906 <tkdgur0906@naver.com>
Co-authored-by: tkdgur0906 <tkdgur0906@naver.com>
Co-authored-by: tkdgur0906 <tkdgur0906@naver.com>
Co-authored-by: tkdgur0906 <tkdgur0906@naver.com>
Co-authored-by: tkdgur0906 <tkdgur0906@naver.com>
Co-authored-by: tkdgur0906 <tkdgur0906@naver.com>
Co-authored-by: tkdgur0906 <tkdgur0906@naver.com>
Co-authored-by: tkdgur0906 <tkdgur0906@naver.com>
Co-authored-by: tkdgur0906 <tkdgur0906@naver.com>
Co-authored-by: tkdgur0906 <tkdgur0906@naver.com>
Co-authored-by: tkdgur0906 <tkdgur0906@naver.com>
Co-authored-by: tkdgur0906 <tkdgur0906@naver.com>
sihyung92
approved these changes
Mar 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
안녕하세요 카피, 리뷰어 웨지입니다.
미션 제출시간을 넘긴 코드는 리뷰 대상이 아니어서 바로 머지합니다 😓
학습의 중요한 계기가 되는 코드리뷰를 생략하는 게 가혹하다 싶다가도,
실제 회사생활에서 마감을 못 지킬 때 겪게 되는 상황과 비교해보면
미션 한번의 학습보다 '마감의 중요성'이라는 교훈을 얻는 게 훨씬 중요한 경험이라는 생각도 듭니다.
Step2 까지 완료하고 다음 요청주세요~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 웨지!
이번 미션 리뷰이 카피입니다!
이번 미션을 정신없이 하느라 스스로 고민하는 시간이 부족했던 것 같습니다😂
리팩토링 하면서 궁금한 것들을 질문드리려고 합니다!
감사합니다!