[1단계 - DB 복제와 캐시] 카피(김상혁) 미션 제출합니다. #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chocochip101
requested changes
Oct 18, 2024
Comment on lines
37
to
39
| Map<Object, Object> dataSourceMap = new HashMap<>(); | ||
| dataSourceMap.put(DataSourceType.WRITER, writeDataSource); | ||
| dataSourceMap.put(DataSourceType.READER, readDataSource); |
There was a problem hiding this comment.
initializeDataSource 메서드로 분리했습니다!
| if (discountAmount < 1000 || discountAmount > 10000) { | ||
| throw new IllegalArgumentException("할인 금액은 1,000원 이상, 10,000원 이하여야 합니다."); | ||
| } | ||
| if (discountAmount % 500 != 0) { |
docker/init.sql
Outdated
| minimumOrderAmount INT NOT NULL, | ||
| discountAmount INT NOT NULL, | ||
| discountRate INT NOT NULL, | ||
| category VARCHAR(255), |
There was a problem hiding this comment.
사실 별 생각없이 적용한 값입니다!
카테고리의 특성상 길이가 길지 않기 떄문에 30으로 해도 적절할 것 같아 수정했습니다!
Chocochip101
approved these changes
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 초코칩!
잘 부탁드립니다~
복제 지연 해결방법에 대해 고민하면서 생각했던 것들에 대해 적어봤어요.
리뷰하실 때 참고 부탁드립니다!
1. 비동기를 동기방식으로 바꾼다
2. 비동기를 반동기방식으로 바꾼다.
3. 코드 상에서 리플리카 서버에 데이터가 없는 경우 소스 서버에 다시 조회하도록 한다.