[3단계 - Tomcat 구현하기] 카피(김상혁) 미션 제출합니다. #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yechop
requested changes
Sep 11, 2024
| @@ -30,7 +41,7 @@ public static HttpRequest from(InputStream inputStream) throws IOException { | |||
| String startLine = bufferedReader.readLine(); | |||
There was a problem hiding this comment.
RequestLine 을 분리하면 어떨까요 (lms 3단계 - 힌트 1 참고)
There was a problem hiding this comment.
저런 힌트가 있었군요! HttpRequestLine 클래스를 생성해서 역할을 분리했습니다!
| @@ -30,7 +41,7 @@ public static HttpRequest from(InputStream inputStream) throws IOException { | |||
| String startLine = bufferedReader.readLine(); | |||
|
|
|||
| String[] parsedStartLine = HttpRequestParser.parseStartLine(startLine); | |||
| String method = parsedStartLine[0]; | |||
| HttpMethod method = HttpMethod.from(parsedStartLine[0]); | |||
| String path = parsedStartLine[1]; | |||
| String version = parsedStartLine[2]; | |||
|
|
|||
There was a problem hiding this comment.
49~56번줄 while문 리팩토링 해주시면 좋을것 같아요.
지금은 while문의 조건이 true나 다름없습니다!
There was a problem hiding this comment.
현재 while 방식으로는 조건문이 의미가 없고 무조건 if에서 처리되겠네요!
while문의 탈출 조건을 변경하였습니다!
| public byte[] toHttpResponseBody() throws URISyntaxException, IOException { | ||
| URL url = getClass().getClassLoader().getResource(loadResourceName(path)); | ||
| if (url == null) { | ||
| throw new IllegalArgumentException("존재하지 않는 리소스 입니다." + path); |
There was a problem hiding this comment.
예외 종류별로 반환코드를 설정하면 좋을 것 같습니다!
다만 다른 기능의 우선순위가 높을 것 같아 추후 고려해보겠습니다!
| } catch (IOException | UncheckedServletException e) { | ||
| log.error(e.getMessage(), e); | ||
| } catch (URISyntaxException e) { | ||
| } catch (Exception e) { |
There was a problem hiding this comment.
알 수 없는 예외가 발생했을 때 500 에러를 반환하는 방어 로직을 작성해야 할 거 같습니다!
이 기능도 위와 동일하게 추후 고려해보겠습니다~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 잉크~
3단계 미션 진행 후 제출합니다!
전반적으로 리팩토링만 진행했습니다!