[2단계 - 웹 자동차 경주] 허브(방대의) 미션 제출합니다.

src/main/java/racingcar/dao/CarDao.java

@@ -4,7 +4,7 @@
 import racingcar.entity.CarEntity;
 
 public interface CarDao {
-    void saveAll(final List<CarEntity> players);
+    void saveAll(final List<CarEntity> cars);
 
     List<CarEntity> findAll();
 }

src/main/java/racingcar/dao/ConsoleCarDao.java

@@ -5,7 +5,7 @@
 
 public class ConsoleCarDao implements CarDao {
     @Override
-    public void saveAll(final List<CarEntity> players) {
+    public void saveAll(final List<CarEntity> cars) {
     }
 
     @Override

src/main/java/racingcar/entity/CarEntity.java

@@ -3,11 +3,11 @@
 import racingcar.domain.Car;
 
 public class CarEntity {
-    private Integer id;
-    private String name;
-    private int position;
-    private boolean winner;
-    private Integer gameId;
+    private final Integer id;
+    private final String name;
+    private final int position;
+    private final boolean winner;
+    private final Integer gameId;
 
     public CarEntity(final String name, final int position, final boolean winner, final Integer gameId) {
         this(null, name, position, winner, gameId);

src/main/java/racingcar/exception/RacingGameExceptionHandler.java

@@ -12,8 +12,8 @@
 public class RacingGameExceptionHandler {
     private static final String DELIMITER = ", ";
 
-    @ExceptionHandler(IllegalArgumentException.class)
-    public ResponseEntity<ExceptionResponse> handleIllegalArgumentException(IllegalArgumentException e) {
+    @ExceptionHandler({IllegalArgumentException.class, IllegalStateException.class})
+    public ResponseEntity<ExceptionResponse> handleIllegalArgumentException(final RuntimeException e) {
         return ResponseEntity.status(HttpStatus.BAD_REQUEST)
                 .body(new ExceptionResponse(e.getMessage()));
     }
@@ -28,7 +28,7 @@ public ResponseEntity<ExceptionResponse> handleValidException(final MethodArgume
     }
 
     @ExceptionHandler(Exception.class)
-    public ResponseEntity<ExceptionResponse> handleException(Exception e) {
+    public ResponseEntity<ExceptionResponse> handleException(final Exception e) {
         return ResponseEntity.status(HttpStatus.INTERNAL_SERVER_ERROR)
                 .body(new ExceptionResponse("서버가 응답할 수 없습니다."));
     }

src/main/java/racingcar/service/RacingGameService.java

@@ -38,15 +38,15 @@ public GamePlayResponseDto play(final GamePlayRequestDto gameRequest) {
 
         final GameEntity gameEntity = racingGameMapper.toGameEntity(gameRequest.getCount());
         final int gameId = gameDao.saveAndGetId(gameEntity)
-                .orElseThrow(() -> new IllegalArgumentException("게임 저장에 실패하였습니다."));
+                .orElseThrow(() -> new IllegalStateException("게임 저장에 실패하였습니다."));
 
         final List<CarEntity> carEntities = racingGameMapper.toCarEntities(game, gameId);
         carDao.saveAll(carEntities);
 
         return GamePlayResponseDto.of(game.findWinners(), game.getCars());
     }
 
-    @Transactional
+    @Transactional(readOnly = true)
     public List<GamePlayResponseDto> findAll() {
         final List<CarEntity> result = carDao.findAll();
         return racingGameMapper.toGamePlayResponseDtos(result);

src/test/java/racingcar/dao/CarJdbcDaoTest.java

@@ -59,15 +59,15 @@ void setUp() {
 
         // when
         final List<CarEntity> result = carDao.findAll();
-        
+
         // then
         final CarEntity carEntity = result.get(0);
         assertAll(
                 () -> assertThat(result).hasSize(2),
                 () -> assertThat(carEntity.getId()).isPositive(),
                 () -> assertThat(carEntity.getName()).isEqualTo("car1"),
                 () -> assertThat(carEntity.getPosition()).isEqualTo(1),
-                () -> assertThat(carEntity.isWinner()).isEqualTo(false),
+                () -> assertThat(carEntity.isWinner()).isFalse(),
                 () -> assertThat(carEntity.getGameId()).isEqualTo(gameId)
         );
     }

src/test/java/racingcar/dao/GameJdbcDaoTest.java

@@ -38,6 +38,6 @@ void setUp() {
         final Optional<Integer> gameId = gameDao.saveAndGetId(game);
 
         // then
-        assertThat(gameId.isPresent()).isTrue();
+        assertThat(gameId).isPresent();
     }
 }

src/test/java/racingcar/integration/RacingGameIntegrationTest.java

@@ -0,0 +1,98 @@
+package racingcar.integration;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.hamcrest.Matchers.hasSize;
+import static org.hamcrest.Matchers.is;
+import static org.mockito.BDDMockito.given;
+import static org.springframework.http.MediaType.APPLICATION_JSON;
+import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get;
+import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.post;
+import static org.springframework.test.web.servlet.result.MockMvcResultHandlers.print;
+import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.jsonPath;
+import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;
+
+import com.fasterxml.jackson.databind.ObjectMapper;
+import java.util.List;
+import org.hamcrest.Matchers;
+import org.junit.jupiter.api.DisplayNameGeneration;
+import org.junit.jupiter.api.DisplayNameGenerator;
+import org.junit.jupiter.api.Test;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.boot.test.autoconfigure.web.servlet.AutoConfigureMockMvc;
+import org.springframework.boot.test.context.SpringBootTest;
+import org.springframework.boot.test.mock.mockito.MockBean;
+import org.springframework.test.web.servlet.MockMvc;
+import org.springframework.transaction.annotation.Transactional;
+import racingcar.dao.CarDao;
+import racingcar.dao.GameDao;
+import racingcar.domain.NumberGenerator;
+import racingcar.dto.GamePlayRequestDto;
+import racingcar.entity.CarEntity;
+import racingcar.entity.GameEntity;
+
+@SpringBootTest
+@AutoConfigureMockMvc
+@Transactional
+@DisplayNameGeneration(DisplayNameGenerator.ReplaceUnderscores.class)
+@SuppressWarnings("NonAsciiCharacters")
+public class RacingGameIntegrationTest {
+
+    @Autowired
+    private MockMvc mockMvc;
+
+    @Autowired
+    private ObjectMapper objectMapper;
+
+    @Autowired
+    private GameDao gameDao;
+
+    @Autowired
+    private CarDao carDao;
+
+    @MockBean
+    private NumberGenerator numberGenerator;
+
+    @Test
+    void 게임을_진행한다() throws Exception {
+        // given
+        final GamePlayRequestDto gamePlayRequestDto = new GamePlayRequestDto(List.of("비버", "허브"), 3);
+        final String request = objectMapper.writeValueAsString(gamePlayRequestDto);
+        given(numberGenerator.generate()).willReturn(7, 3, 3, 4, 5, 2);
+
+        // expect
+        mockMvc.perform(post("/plays")
+                        .content(request)
+                        .contentType(APPLICATION_JSON))
+                .andExpect(status().isCreated())
+                .andExpect(jsonPath("$.winners", Matchers.contains("비버")))
+                .andExpect(jsonPath("$.racingCars", hasSize(2)))
+                .andExpect(jsonPath("$.racingCars[0].name", is("비버")))
+                .andExpect(jsonPath("$.racingCars[0].position").value(2))
+                .andExpect(jsonPath("$.racingCars[1].name", is("허브")))
+                .andExpect(jsonPath("$.racingCars[1].position").value(1))
+                .andDo(print());
+        assertThat(carDao.findAll()).hasSize(2);
+    }
+
+    @Test
+    void 게임_결과를_반환한다() throws Exception {
+        // given
+        final Integer gameId = gameDao.saveAndGetId(new GameEntity(9999)).get();
+        carDao.saveAll(List.of(
+                new CarEntity("비버", 5, true, gameId),
+                new CarEntity("허브", 4, false, gameId)
+        ));
+
+        // expect
+        mockMvc.perform(get("/plays")
+                        .contentType(APPLICATION_JSON))
+                .andExpect(status().isOk())
+                .andExpect(jsonPath("$[0].winners", Matchers.contains("비버")))
+                .andExpect(jsonPath("$[0].racingCars", hasSize(2)))
+                .andExpect(jsonPath("$[0].racingCars[0].name", is("비버")))
+                .andExpect(jsonPath("$[0].racingCars[0].position").value(5))
+                .andExpect(jsonPath("$[0].racingCars[1].name", is("허브")))
+                .andExpect(jsonPath("$[0].racingCars[1].position").value(4))
+                .andDo(print());
+    }
+}

src/test/java/racingcar/service/RacingGameServiceTest.java

@@ -1,6 +1,7 @@
 package racingcar.service;
 
 import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
 import static org.junit.jupiter.api.Assertions.assertAll;
 import static org.mockito.ArgumentMatchers.any;
 import static org.mockito.BDDMockito.given;
@@ -60,6 +61,18 @@ void setUp() {
         );
     }
 
+    @Test
+    void play_메서드_저장_후_빈_아이디를_반환받는_경우_IllegalStateException을_던진다() {
+        // given
+        final GamePlayRequestDto request = new GamePlayRequestDto(List.of("브리", "비버", "허브"), 1);
+        given(gameDao.saveAndGetId(any())).willReturn(Optional.empty());
+
+        // expect
+        assertThatThrownBy(() -> racingGameService.play(request))
+                .isInstanceOf(IllegalStateException.class)
+                .hasMessage("게임 저장에 실패하였습니다.");
+    }
+
     @Test
     void findAll_메서드는_게임_결과를_반환한다() {
         // given