Skip to content

Commit

Permalink
[페이먼츠 미션 Step 3] 센트(김영우) 미션 제출합니다. (#293)
Browse files Browse the repository at this point in the history
* style: Array.from.forEach => card.정보.forEach

* chore: 배포한 모달 패키지 설치

* refactor: 배포한 모달 패키지 사용

* feat: 로딩 스켈레톤 추가
  • Loading branch information
kyw0716 authored May 8, 2023
1 parent a5c5b4c commit 11eff1e
Show file tree
Hide file tree
Showing 17 changed files with 360 additions and 175 deletions.
180 changes: 171 additions & 9 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
]
},
"devDependencies": {
"@kyw0716/woowacourse-scent-modal": "^0.0.5",
"@storybook/addon-essentials": "^7.0.5",
"@storybook/addon-interactions": "^7.0.5",
"@storybook/addon-links": "^7.0.5",
Expand Down
2 changes: 1 addition & 1 deletion src/App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ import { Main } from './pages/Main';
import { Register } from './pages/register';
import { AddCardNickName } from './pages/register/AddCardNickName';
import { CardInfoProvider } from './components/providers/CardInfoProvider';
import { ModalProvider } from './components/providers/ModalProvider';
import { CardListProvider } from './components/providers/CardListProvider';
import { ModalProvider } from '@kyw0716/woowacourse-scent-modal';

function App() {
return (
Expand Down
10 changes: 1 addition & 9 deletions src/components/addCardForm/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ import {
useCardInfoActionContext,
useCardInfoValueContext,
} from '../../hooks/cardInfoContext';
import { useModalStateContext } from '../../hooks/useModalContext';
import { v4 } from 'uuid';
import { useCardList } from '../../hooks/useCardList';
import { useFormValidation } from '../../hooks/useFormValidation';
import { useModalStateContext } from '@kyw0716/woowacourse-scent-modal';

export const AddNewCardForm = () => {
const navigate = useNavigate();
Expand Down Expand Up @@ -107,14 +107,6 @@ const Style = {
width: max-content;
`,
// InputContainer: styled.div`
// display: flex;
// flex-direction: column;

// width: max-content;

// gap: 19px;
// `,
Caption: styled.span`
width: 241px;
Expand Down
2 changes: 1 addition & 1 deletion src/components/cardViewer/index.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import styled from 'styled-components';
import { v4 } from 'uuid';
import { COMPANIES } from '../../constants/cardCompany';
import { isCompanyId } from '../modal/content/selectCardCompany';
import { isCompanyId } from '../selectCardCompany';
import { CardViewerProps } from '../../types/card';

interface Props extends CardViewerProps {
Expand Down
57 changes: 0 additions & 57 deletions src/components/modal/template/BottomSheet.tsx

This file was deleted.

38 changes: 0 additions & 38 deletions src/components/providers/ModalProvider.tsx

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import styled from 'styled-components';
import { COMPANIES } from '../../../../constants/cardCompany';
import { COMPANIES } from '../../constants/cardCompany';

interface Props {
companyId: string;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import styled from 'styled-components';
import { COMPANIES } from '../../../../constants/cardCompany';
import { COMPANIES } from '../../constants/cardCompany';
import { CardCompany } from './CardCompany';
import { v4 } from 'uuid';
import { useCardInfoActionContext } from '../../../../hooks/cardInfoContext';
import { useModalActionContext } from '../../../../hooks/useModalContext';
import { useCardInfoActionContext } from '../../hooks/cardInfoContext';
import { useModalActionContext } from '@kyw0716/woowacourse-scent-modal';

export const isCompanyId = (
id: string | undefined
Expand Down
Loading

0 comments on commit 11eff1e

Please sign in to comment.