Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1 - 3단계 방탈출 사용자 예약] 이든(최승준) 미션 제출합니다. #57

Merged
merged 61 commits into from
May 7, 2024
Merged

[1 - 3단계 방탈출 사용자 예약] 이든(최승준) 미션 제출합니다. #57

merged 61 commits into from
May 7, 2024

Commits on Apr 30, 2024

  1. init: 이전 미션 코드 반영

    @J-I-H-O
    J-I-H-O committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    bd5a99e View commit details
    Browse the repository at this point in the history

  2. style: 줄바꿈 수정

    @PgmJun
    PgmJun committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    b0bd9bb View commit details
    Browse the repository at this point in the history

  3. docs: 예외 상황 정의 

    Co-authored-by: PgmJun <chltmdwns96@gmail.com>
Co-authored-by: J-I-H-O <jeongjiho0731@gmail.com>
    @J-I-H-O @PgmJun
    J-I-H-O and PgmJun committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    ba6b536 View commit details
    Browse the repository at this point in the history

  4. feat: 유효하지 않은 시간 생성 검증 기능 구현 

    Co-authored-by: PgmJun <chltmdwns96@gmail.com>
Co-authored-by: J-I-H-O <jeongjiho0731@gmail.com>
    @J-I-H-O @PgmJun
    J-I-H-O and PgmJun committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    3592c1d View commit details
    Browse the repository at this point in the history

  5. feat: 유효하지 않은 시간 생성 검증 기능 구현 

    Co-authored-by: PgmJun <chltmdwns96@gmail.com>
Co-authored-by: J-I-H-O <jeongjiho0731@gmail.com>
    @J-I-H-O @PgmJun
    J-I-H-O and PgmJun committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    75c7ee4 View commit details
    Browse the repository at this point in the history

  6. feat: 예약이 존재하는 시간 삭제를 방어하는 기능 구현 

    Co-authored-by: PgmJun <chltmdwns96@gmail.com>
Co-authored-by: J-I-H-O <jeongjiho0731@gmail.com>
    @J-I-H-O @PgmJun
    J-I-H-O and PgmJun committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    ec2e3b0 View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'origin/step1' into step1

    @J-I-H-O
    J-I-H-O committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    e37964d View commit details
    Browse the repository at this point in the history

  8. style: 줄바꿈 정리

    @J-I-H-O
    J-I-H-O committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    a8a4a02 View commit details
    Browse the repository at this point in the history

  9. feat: 유효하지 않은 예약 등록 요청 검증 로직 구현 

    Co-authored-by: PgmJun <chltmdwns96@gmail.com>
Co-authored-by: J-I-H-O <jeongjiho0731@gmail.com>
    @J-I-H-O @PgmJun
    J-I-H-O and PgmJun committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    0fe2794 View commit details
    Browse the repository at this point in the history

  10. feat: 중복된 날짜 및 시간 예약 등록 검증 로직 구현 

    Co-authored-by: PgmJun <chltmdwns96@gmail.com>
Co-authored-by: J-I-H-O <jeongjiho0731@gmail.com>
    @J-I-H-O @PgmJun
    J-I-H-O and PgmJun committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    540fdee View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. chore: gradle 설정 변경 

    Co-authored-by: PgmJun <chltmdwns96@gmail.com>
Co-authored-by: J-I-H-O <jeongjiho0731@gmail.com>
    @J-I-H-O @PgmJun
    J-I-H-O and PgmJun committed May 1, 2024
    Configuration menu
    Copy the full SHA
    5d6008e View commit details
    Browse the repository at this point in the history

  2. feat: 지나간 날짜와 시간에 대한 예약 생성 방지 기능 구현 

    Co-authored-by: PgmJun <chltmdwns96@gmail.com>
Co-authored-by: J-I-H-O <jeongjiho0731@gmail.com>
    @J-I-H-O @PgmJun
    J-I-H-O and PgmJun committed May 1, 2024
    Configuration menu
    Copy the full SHA
    7307152 View commit details
    Browse the repository at this point in the history

  3. docs: 테마 API 명세 추가 

    Co-authored-by: PgmJun <chltmdwns96@gmail.com>
Co-authored-by: J-I-H-O <jeongjiho0731@gmail.com>
    @J-I-H-O @PgmJun
    J-I-H-O and PgmJun committed May 1, 2024
    Configuration menu
    Copy the full SHA
    4f592bd View commit details
    Browse the repository at this point in the history

  4. chore: 테마 관련 DDL 추가 

    Co-authored-by: PgmJun <chltmdwns96@gmail.com>
Co-authored-by: J-I-H-O <jeongjiho0731@gmail.com>
    @J-I-H-O @PgmJun
    J-I-H-O and PgmJun committed May 1, 2024
    Configuration menu
    Copy the full SHA
    7331554 View commit details
    Browse the repository at this point in the history

  5. feat: 테마 관리 페이지 요청 API 구현 

    Co-authored-by: PgmJun <chltmdwns96@gmail.com>
Co-authored-by: J-I-H-O <jeongjiho0731@gmail.com>
    @J-I-H-O @PgmJun
    J-I-H-O and PgmJun committed May 1, 2024
    Configuration menu
    Copy the full SHA
    17af3db View commit details
    Browse the repository at this point in the history

  6. fix: 예약 관리 페이지 파일 변경 

    Co-authored-by: PgmJun <chltmdwns96@gmail.com>
Co-authored-by: J-I-H-O <jeongjiho0731@gmail.com>
    @J-I-H-O @PgmJun
    J-I-H-O and PgmJun committed May 1, 2024
    Configuration menu
    Copy the full SHA
    9e8790e View commit details
    Browse the repository at this point in the history

  7. docs: 테마 관련 REST API 명세 추가 

    Co-authored-by: PgmJun <chltmdwns96@gmail.com>
Co-authored-by: J-I-H-O <jeongjiho0731@gmail.com>
    @J-I-H-O @PgmJun
    J-I-H-O and PgmJun committed May 1, 2024
    Configuration menu
    Copy the full SHA
    e951bbb View commit details
    Browse the repository at this point in the history

  8. feat: 테마 조회 기능 구현 

    Co-authored-by: PgmJun <chltmdwns96@gmail.com>
Co-authored-by: J-I-H-O <jeongjiho0731@gmail.com>
    @J-I-H-O @PgmJun
    J-I-H-O and PgmJun committed May 1, 2024
    Configuration menu
    Copy the full SHA
    3bbd400 View commit details
    Browse the repository at this point in the history

  9. feat: 테마 추가 기능 구현

    @J-I-H-O
    J-I-H-O committed May 1, 2024
    Configuration menu
    Copy the full SHA
    40d021b View commit details
    Browse the repository at this point in the history

  10. feat: 테마 삭제 기능 구현 

    Co-authored-by: PgmJun <chltmdwns96@gmail.com>
Co-authored-by: J-I-H-O <jeongjiho0731@gmail.com>
    @J-I-H-O @PgmJun
    J-I-H-O and PgmJun committed May 1, 2024
    Configuration menu
    Copy the full SHA
    ff72e78 View commit details
    Browse the repository at this point in the history

  11. feat: 예약 도메인과 테마 도메인 연동 

    Co-authored-by: PgmJun <chltmdwns96@gmail.com>
Co-authored-by: J-I-H-O <jeongjiho0731@gmail.com>
    @J-I-H-O @PgmJun
    J-I-H-O and PgmJun committed May 1, 2024
    Configuration menu
    Copy the full SHA
    fe93600 View commit details
    Browse the repository at this point in the history

  12. feat: 사용자 예약 페이지 요청 API 구현 

    Co-authored-by: PgmJun <chltmdwns96@gmail.com>
Co-authored-by: J-I-H-O <jeongjiho0731@gmail.com>
    @J-I-H-O @PgmJun
    J-I-H-O and PgmJun committed May 1, 2024
    Configuration menu
    Copy the full SHA
    60d7ed3 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. chore: 더미 데이터 삽입 SQL 작성 

    Co-authored-by: PgmJun <chltmdwns96@gmail.com>
Co-authored-by: J-I-H-O <jeongjiho0731@gmail.com>
    @J-I-H-O @PgmJun
    J-I-H-O and PgmJun committed May 2, 2024
    Configuration menu
    Copy the full SHA
    478963c View commit details
    Browse the repository at this point in the history

  2. feat: 특정 날짜의 특정 테마 예약 정보 조회 기능 구현 

    Co-authored-by: PgmJun <chltmdwns96@gmail.com>
Co-authored-by: J-I-H-O <jeongjiho0731@gmail.com>
    @J-I-H-O @PgmJun
    J-I-H-O and PgmJun committed May 2, 2024
    Configuration menu
    Copy the full SHA
    45fbf52 View commit details
    Browse the repository at this point in the history

  3. docs: 인기 테마 API 명세 추가 

    Co-authored-by: PgmJun <chltmdwns96@gmail.com>
Co-authored-by: J-I-H-O <jeongjiho0731@gmail.com>
    @J-I-H-O @PgmJun
    J-I-H-O and PgmJun committed May 2, 2024
    Configuration menu
    Copy the full SHA
    efb21f8 View commit details
    Browse the repository at this point in the history

  4. feat: 인기 테마 조회 기능 구현 

    Co-authored-by: PgmJun <chltmdwns96@gmail.com>
Co-authored-by: J-I-H-O <jeongjiho0731@gmail.com>
    @J-I-H-O @PgmJun
    J-I-H-O and PgmJun committed May 2, 2024
    Configuration menu
    Copy the full SHA
    f7177bd View commit details
    Browse the repository at this point in the history

  5. refactor: 테스트 성능 개선 

    Co-authored-by: PgmJun <chltmdwns96@gmail.com>
Co-authored-by: J-I-H-O <jeongjiho0731@gmail.com>
    @J-I-H-O @PgmJun
    J-I-H-O and PgmJun committed May 2, 2024
    Configuration menu
    Copy the full SHA
    1f76b8f View commit details
    Browse the repository at this point in the history

  6. refactor: 메서드 분리 

    Co-authored-by: PgmJun <chltmdwns96@gmail.com>
Co-authored-by: J-I-H-O <jeongjiho0731@gmail.com>
    @J-I-H-O @PgmJun
    J-I-H-O and PgmJun committed May 2, 2024
    Configuration menu
    Copy the full SHA
    772631f View commit details
    Browse the repository at this point in the history

  7. style: 완료된 TODO 제거 

    Co-authored-by: PgmJun <chltmdwns96@gmail.com>
Co-authored-by: J-I-H-O <jeongjiho0731@gmail.com>
    @J-I-H-O @PgmJun
    J-I-H-O and PgmJun committed May 2, 2024
    Configuration menu
    Copy the full SHA
    ac95a28 View commit details
    Browse the repository at this point in the history

  8. style: 테스트 given, when, then 분리 

    Co-authored-by: PgmJun <chltmdwns96@gmail.com>
Co-authored-by: J-I-H-O <jeongjiho0731@gmail.com>
    @J-I-H-O @PgmJun
    J-I-H-O and PgmJun committed May 2, 2024
    Configuration menu
    Copy the full SHA
    830df0c View commit details
    Browse the repository at this point in the history

  9. style: TODO 제거 

    Co-authored-by: PgmJun <chltmdwns96@gmail.com>
Co-authored-by: J-I-H-O <jeongjiho0731@gmail.com>
    @J-I-H-O @PgmJun
    J-I-H-O and PgmJun committed May 2, 2024
    Configuration menu
    Copy the full SHA
    cd175dc View commit details
    Browse the repository at this point in the history

  10. docs: 테마 인기순 조회 API 문서 작성

    @PgmJun
    PgmJun committed May 2, 2024
    Configuration menu
    Copy the full SHA
    2d9aa37 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2024

  1. refactor: 컨트롤러 공통 Endpoint 매핑 해제

    @PgmJun
    PgmJun committed May 4, 2024
    Configuration menu
    Copy the full SHA
    23b6a97 View commit details
    Browse the repository at this point in the history

  2. style: 메서드 인자 개행 수정

    @PgmJun
    PgmJun committed May 4, 2024
    Configuration menu
    Copy the full SHA
    35935dc View commit details
    Browse the repository at this point in the history

  3. style: 코드라인 정리

    @PgmJun
    PgmJun committed May 4, 2024
    Configuration menu
    Copy the full SHA
    5604c83 View commit details
    Browse the repository at this point in the history

  4. refactor: HTTP Response 형식 수정(List -> Object)

    @PgmJun
    PgmJun committed May 4, 2024
    Configuration menu
    Copy the full SHA
    230ce75 View commit details
    Browse the repository at this point in the history

  5. style: 컨트롤러 메서드 네이밍 변경

    @PgmJun
    PgmJun committed May 4, 2024
    Configuration menu
    Copy the full SHA
    4cec0d8 View commit details
    Browse the repository at this point in the history

  6. style: DAO 메서드 네이밍 변경

    @PgmJun
    PgmJun committed May 4, 2024
    Configuration menu
    Copy the full SHA
    04131d6 View commit details
    Browse the repository at this point in the history

  7. style: Service 메서드 네이밍 변경

    @PgmJun
    PgmJun committed May 4, 2024
    Configuration menu
    Copy the full SHA
    a0899cf View commit details
    Browse the repository at this point in the history

  8. refactor: 메서드 인자 final로 불변 처리

    @PgmJun
    PgmJun committed May 4, 2024
    Configuration menu
    Copy the full SHA
    7b816fd View commit details
    Browse the repository at this point in the history

Commits on May 5, 2024

  1. refactor: 예약 시간 정보 조회 API Endpoint 수정

    @PgmJun
    PgmJun committed May 5, 2024
    Configuration menu
    Copy the full SHA
    4a9a980 View commit details
    Browse the repository at this point in the history

  2. refactor: 테스트에서 컴포넌트 객체 사용을 위해 Import 애노테이션 적용

    @PgmJun
    PgmJun committed May 5, 2024
    Configuration menu
    Copy the full SHA
    0f8ef2c View commit details
    Browse the repository at this point in the history

  3. refactor: 예외 발생 시 Response도 Object로 처리하도록, 응답 객체 ApiResponse 구현 

    그저 String을 return하는 방식은 이후 응답 데이터 확장 설계를 할 때
클라이언트의 응답값 흭득 방식에 변경이 발생해야하기 때문에 break change가 발생
때문에 요청 정보/에러 정보를 담은 응답 객체(ApiResponse)를 두어 사용
    @PgmJun
    PgmJun committed May 5, 2024
    Configuration menu
    Copy the full SHA
    0470138 View commit details
    Browse the repository at this point in the history

  4. test: MVC Controller 테스트 작성

    @PgmJun
    PgmJun committed May 5, 2024
    Configuration menu
    Copy the full SHA
    c983dfd View commit details
    Browse the repository at this point in the history

  5. feat: 입력부 검증 로직 구현

    @PgmJun
    PgmJun committed May 5, 2024
    Configuration menu
    Copy the full SHA
    41fa7a2 View commit details
    Browse the repository at this point in the history

  6. feat: 도메인 검증 로직 구현

    @PgmJun
    PgmJun committed May 5, 2024
    Configuration menu
    Copy the full SHA
    818b1eb View commit details
    Browse the repository at this point in the history

  7. refactor: 예약 시간 정보 조회 로직 - 서브 쿼리 사용하여 하나의 SQL로 조회하도록 수정

    @PgmJun
    PgmJun committed May 5, 2024
    Configuration menu
    Copy the full SHA
    a2905fc View commit details
    Browse the repository at this point in the history

  8. refactor: 테스트 코드 @BeforeEach 제거하고 필요한 곳에서만 데이터 삽입해주도록 변경

    @PgmJun
    PgmJun committed May 5, 2024
    Configuration menu
    Copy the full SHA
    79de6f5 View commit details
    Browse the repository at this point in the history

  9. fix: 00:30분 일때 1시간 전은 23:30분 이기 때문에 다른 날짜로 판별되어 테스트코드 실패하는 문제 해결

    @PgmJun
    PgmJun committed May 5, 2024
    Configuration menu
    Copy the full SHA
    604a0c0 View commit details
    Browse the repository at this point in the history

  10. style: Repository 네이밍 용도에 맞도록 Dao로 변경

    @PgmJun
    PgmJun committed May 5, 2024
    Configuration menu
    Copy the full SHA
    a0f45d0 View commit details
    Browse the repository at this point in the history

  11. refactor: 특정 기간 사이 인기테마 조회 API 쿼리스트링으로 날짜값 받도록 변경

    @PgmJun
    PgmJun committed May 5, 2024
    Configuration menu
    Copy the full SHA
    15276bd View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. refactor: 의미가 불분명한 ConflictException 네이밍 변경 (DataConflictException)

    @PgmJun
    PgmJun committed May 6, 2024
    Configuration menu
    Copy the full SHA
    b40b582 View commit details
    Browse the repository at this point in the history

  2. refactor: 에러 메시지 클라이언트 친화적으로 개선

    @PgmJun
    PgmJun committed May 6, 2024
    Configuration menu
    Copy the full SHA
    7620bc5 View commit details
    Browse the repository at this point in the history

  3. refactor: Location 헤더 상수 사용하도록 변경

    @PgmJun
    PgmJun committed May 6, 2024
    Configuration menu
    Copy the full SHA
    f6b6e37 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. refactor: 로깅 예외 메시지 구체화

    @PgmJun
    PgmJun committed May 7, 2024
    Configuration menu
    Copy the full SHA
    4014865 View commit details
    Browse the repository at this point in the history

  2. refactor: 인기테마 조회 API에 defaultValue 적용

    @PgmJun
    PgmJun committed May 7, 2024
    Configuration menu
    Copy the full SHA
    80690a0 View commit details
    Browse the repository at this point in the history

  3. refactor: 복잡성 제거를 위해 ApiResponse isSuccess 필드 제거

    @PgmJun
    PgmJun committed May 7, 2024
    Configuration menu
    Copy the full SHA
    272a414 View commit details
    Browse the repository at this point in the history

  4. refactor: 예약 시간 정보 조회 쿼리에서 의미없는 조인 쿼리 제거

    @PgmJun
    PgmJun committed May 7, 2024
    Configuration menu
    Copy the full SHA
    3175c22 View commit details
    Browse the repository at this point in the history

  5. refactor: 조건식 가독성 향상을 위한 조건문 분리

    @PgmJun
    PgmJun committed May 7, 2024
    Configuration menu
    Copy the full SHA
    81687e0 View commit details
    Browse the repository at this point in the history

  6. fix: 잘못된 예외 객체 사용 로직 수정 (DataConflict -> Validate)

    @PgmJun
    PgmJun committed May 7, 2024
    Configuration menu
    Copy the full SHA
    bc3aaf6 View commit details
    Browse the repository at this point in the history

  7. fix: 불필요한 포맷팅 애노테이션 제거

    @PgmJun
    PgmJun committed May 7, 2024
    Configuration menu
    Copy the full SHA
    a80fcbd View commit details
    Browse the repository at this point in the history