Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new dimens and style parameter to change heading vertical space #871

Merged
merged 1 commit into from
Nov 13, 2019

Conversation

maxme
Copy link
Contributor

@maxme maxme commented Nov 12, 2019

Feature

New parameter to update the heading vertical space from style file.

Current (8dp) 4dp 0dp
Screenshot_1573550923 Screenshot_1573550910 Screenshot_1573550891

Test

  1. Update heading_vertical_padding in dimens.xml
  2. Run the demo app and check the padding for headings changed.

Note: this is required to fix this issue wordpress-mobile/gutenberg-mobile#992

@maxme maxme force-pushed the feature/add-heading-vertical-padding-parameter branch from 94afefa to a24a227 Compare November 12, 2019 15:40
Copy link
Contributor

@daniloercoli daniloercoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM!

@maxme maxme merged commit 226dffe into develop Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants