-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly bump podspec version #388
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hassaanelgarem Sorry for missing this earlier! 😞
JFYI you'll need to publish the new beta version by creating a release on the Releases page (Make sure to set the pre-release
check), targeting trunk. (Ref: paNNhX-33-p2)
Btw, I have a question for you @mokagio -- Should we release 1.8.3 on the Releases page? 1.8.3 is the latest stable release but on the Releases page I'm seeing 1.8.0 as the latest non-beta release.
@momo-ozawa I was unaware of this process, thanks for the instructions 🙏 |
Hey @AliSoftware! 👋 |
Yes I think it'd be a good idea to publish the missing GitHub Releases for those stable versions ( The important technical bit — the one that triggers the push of the pod to CocoaPods' trunk / CDN — is that a tag has been made; but it doesn't hurt to create a GH release as well, especially since that's what act as our CHANGELOG for this pod nowadays (we don't seem to really maintain Personally what I usually do is I go create the GitHub Release directly when I want to release a new version… which creates the git tag for me as a side effect once I publish that GH Release. |
@AliSoftware Thanks for your input! 🙇♀️
Sounds good! I'll go ahead and publish 1.8.1, 1.8.2 and 1.8.3 and use the existing tags for these.
Same! 😄 |
This PR only changes the podspec version as it was incorrectly updated in #387