Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly bump podspec version #388

Merged
merged 2 commits into from
May 10, 2022
Merged

Conversation

hassaanelgarem
Copy link
Contributor

This PR only changes the podspec version as it was incorrectly updated in #387

@hassaanelgarem hassaanelgarem self-assigned this May 10, 2022
@hassaanelgarem hassaanelgarem requested a review from momo-ozawa May 10, 2022 03:31
Copy link

@momo-ozawa momo-ozawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hassaanelgarem Sorry for missing this earlier! 😞

JFYI you'll need to publish the new beta version by creating a release on the Releases page (Make sure to set the pre-release check), targeting trunk. (Ref: paNNhX-33-p2)

Btw, I have a question for you @mokagio -- Should we release 1.8.3 on the Releases page? 1.8.3 is the latest stable release but on the Releases page I'm seeing 1.8.0 as the latest non-beta release.

@hassaanelgarem
Copy link
Contributor Author

@momo-ozawa I was unaware of this process, thanks for the instructions 🙏

@hassaanelgarem hassaanelgarem merged commit caef8f2 into trunk May 10, 2022
@hassaanelgarem hassaanelgarem deleted the issue/386-empty-view-placement branch May 10, 2022 11:08
@momo-ozawa
Copy link

Should we release 1.8.3 on the Releases page? 1.8.3 is the latest stable release but on the Releases page I'm seeing 1.8.0 as the latest non-beta release.

Hey @AliSoftware! 👋
I didn't realize that Gio is AFK -- what do you think about this?

@AliSoftware
Copy link
Contributor

AliSoftware commented May 11, 2022

Should we release 1.8.3 on the Releases page? 1.8.3 is the latest stable release but on the Releases page I'm seeing 1.8.0 as the latest non-beta release.

Hey @AliSoftware! 👋 I didn't realize that Gio is AFK -- what do you think about this?

Yes I think it'd be a good idea to publish the missing GitHub Releases for those stable versions (1.8.1, 1.8.2 and 1.8.3), just to be consistent and for good OSS etiquette. 👍

The important technical bit — the one that triggers the push of the pod to CocoaPods' trunk / CDN — is that a tag has been made; but it doesn't hurt to create a GH release as well, especially since that's what act as our CHANGELOG for this pod nowadays (we don't seem to really maintain CHANGELOG.md with fancy details on this repo anymore?).

Personally what I usually do is I go create the GitHub Release directly when I want to release a new version… which creates the git tag for me as a side effect once I publish that GH Release.

@momo-ozawa
Copy link

@AliSoftware Thanks for your input! 🙇‍♀️

Yes I think it'd be a good idea to publish the missing GitHub Releases for those stable versions (1.8.1, 1.8.2 and 1.8.3), just to be consistent and for good OSS etiquette. 👍

Sounds good! I'll go ahead and publish 1.8.1, 1.8.2 and 1.8.3 and use the existing tags for these.

Personally what I usually do is I go create the GitHub Release directly when I want to release a new version… which creates the git tag for me as a side effect once I publish that GH Release.

Same! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants