-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash when pasting text on Samsung Devices running Android 8 #8827
Comments
Steps to reproduce:
Result : App will crash Tested with: Galaxy Tab A (2016), Android 8.1 |
Update : Also reproduced on Samsung Galaxy S9, Android 8.0 from browserstack.com account |
Thanks @daniloercoli ! I have closed that one. |
As I need to get back to gb-mobile, I will leave the summary of my work here. Bug summary: Samsung devices has an option to paste the text from CLIPBAORD ListView which is unique functionallity comparing to other products. We have a line of code here : https://github.com/wordpress-mobile/AztecEditor-Android/blob/d570acad6c7d9eed029bb324aa1b78a94a82dce6/aztec/src/main/kotlin/org/wordpress/aztec/AztecText.kt#L1378 Test Case: Problem Here are the notes which I have written while trying to solve above problem. Notes:
Let me know if you have some questions while working on this one. |
reference: 5a8aafe48cb3c2fa635d5605-fabric marked as high priority as it's happening ~40 times/day and affecting ~1000 users Noting that this crash is still happening in 11.9 and happened overall 1189 times (~40 times a day) for 440 users from Feb 14 - Mar 14, 2019. |
This seems a bit similar to #8828. Since we are able to replicate this issue, I'd suggest trying to disable the HardwareAcceleration ->if it fixes the crash, I believe we can merge these two tickets together. Simply add |
This issue is happening when you use the Samsung custom clipboard. Not happening if you use the standard Setting |
I'm sorry for not being clear - I wasn't suggesting we should disable the hardwareAcceleration in the manifest in production. I suggested it only to test whether it fixes the crash so we can decide whether to merge the issues or not. I just want to make sure we won't release two fixes for both issues even though one fix would be enough. However, since it seems the fix for 8828 won't be merged any time soon if ever, fixing this issue makes sense. |
Fixed in wordpress-mobile/AztecEditor-Android#795! |
A user running WP 13.0.1 on a Samsung SM-A520F device with Android 8 is reporting seeing the following message when they try to paste content into the visual editor (they checked both Aztec and the block editor).
To double check, is this the expected behavior? If so, I think the best advice for the user will be to paste in HTML Mode or upgrade to the latest version of Android if at all possible. Do you agree? (internal reference: 2291211-zen) |
They should see both options "Clipboard and Paste". It seems they see only "Clipboard", which doesn't work as expected and hence is disabled. I'm not sure why they don't see regular "Paste" 🤷♂.
Tbh I'm not sure:D. I think the feature is disabled in both visual and html editors. Newer version of Android isn't officially supported :(. @daniloercoli any ideas? |
Sentry issue: WORDPRESS-ANDROID-8W |
@jd-alexander Good find on the related issue ;). Since the new crash in Sentry seems to be happening only on Android 7, I'd consider creating a brand new issue with a link to this issue. Another option is to re-open this issue and update its title, but a lot of the comments might be confusing since they are explicitly mentioning Android 8. Wdyt? |
I will opt for creating the new issue and linking it to this one :) |
It appears we're getting a crash specific to Samsung devices with Android 8.
The relevant bits of the stack trace:
The
android.widget.TextView.pasteClipBoardData
part seems like the main issue AFAICT.reference: 5a8aafe48cb3c2fa635d5605-fabric
marked as high priority as it's happening ~40 times/day and affecting ~1000 users
The text was updated successfully, but these errors were encountered: