Resolved clipboard issue on Android 7.0 #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I saw some other members utilizing https://www.browserstack.com/ for testing. I am thinking to create a WP Android branch with this as an artifact so that an APK can be generated that would make testing possible on those platforms. |
malinajirka
reviewed
Dec 4, 2019
malinajirka
reviewed
Dec 4, 2019
jd-alexander
force-pushed
the
issue/samsung-clipboard
branch
from
13dba9c
to
af1e734
Compare
malinajirka
approved these changes
Dec 8, 2019
There was a problem hiding this comment.
Thanks @jd-alexander ! I haven't tested it, since I don't have an access to a samsung device running Android 7, but the changes LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
wordpress-mobile/WordPress-Android#10872
This solution shows a warning instead of crashing when clipboard functionality is utilized on Samsung devices running Android 7.0.
Test
Use testing instructions as described here
Note
This hasn't been tested on a device as yet as I was unable to secure a Samsung device with the specifications and doing it using an emulator wasn't causing the same result.
Review
@malinajirka
Make sure strings will be translated:
strings.xmlas a part of the integration PR.