Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable gallery upload options in production #11234

Closed
wants to merge 5 commits into from
Closed

Enable gallery upload options in production #11234

wants to merge 5 commits into from

Conversation

mkevins
Copy link
Contributor

@mkevins mkevins commented Feb 5, 2020 •
edited
Loading

Sibling PRs

Description

This PR enables gallery block upload options in production (on mobile).

To test: wordpress-mobile/gutenberg-mobile#1610 (comment)

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

This was referenced Feb 5, 2020
Merged
Merged
Merged
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Feb 5, 2020 •
edited
Loading

You can test the changes on this Pull Request by downloading the APK here.

@mkevins mkevins mentioned this pull request Feb 6, 2020
Closed
@mkevins mkevins requested a review from chipsnyder February 6, 2020 08:10
@pinarol
Copy link
Contributor

pinarol commented Feb 6, 2020

cc @iamthomasbishop Gallery upload options are ready for testing
test cases and list of known issues are here

@mkevins mkevins mentioned this pull request Feb 10, 2020
Merged
3 tasks
chipsnyder
chipsnyder approved these changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@chipsnyder chipsnyder left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the cases here and it worked great! Great work :)
wordpress-mobile/gutenberg-mobile#1610 (comment)

@mkevins
Copy link
Contributor Author

mkevins commented Feb 13, 2020

Closing as this PR was for testing purposing only (wordpress-mobile/gutenberg-mobile#1855 has been merged).

@mkevins mkevins closed this Feb 13, 2020
@mkevins mkevins deleted the feature/gallery-upload-options branch February 13, 2020 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chipsnyder chipsnyder chipsnyder approved these changes

Assignees
No one assigned
Labels
Media [Type] Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkevins @pinarol @chipsnyder