Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack Focus: Handle create page flow for phase four #17738

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

zwarm
Copy link
Contributor

@zwarm zwarm commented Jan 10, 2023

Parent #17339

This PR removes the first step in the page creation flow (template selection) when phase four is enabled.
Creating a page from scratch will still be supported.

To test:

  • Download and install the WP app
  • Login
  • Navigate to the My Site tab
  • Tap on the floating action button and select Site Page
  • ✅ Verify that the Site Page flow is started and the template view is visible
  • Navigate back out to My Site
  • Navigate to the Pages list
  • On the pages list, tap on the floating action button
  • ✅ Verify that the Site page flow is started and the template view is visible
  • Navigate to -> Debug Settings -> and Enable jp_removal_four and restart the app
  • Navigate to the My Site tab
  • Tap on the floating action button and select Site Page
  • ✅ Verify that the create page view is visible and the template view is no longer visible
  • Navigate back to My Site
  • Navigate to the Pages list
  • On the pages list, tap on the floating action button
  • ✅ Verify that the create page view is visible and the template view is no longer visible

Regression Notes

  1. Potential unintended areas of impact
    The create page flow still shows the template view

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@zwarm zwarm added this to the 21.6 milestone Jan 10, 2023
@zwarm zwarm requested a review from AjeshRPai January 10, 2023 20:33
@zwarm zwarm self-assigned this Jan 10, 2023
@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test these changes on Jetpack by downloading jetpack-installable-build-pr17738-b2feee0.apk
💡 Scan this QR code with your Android phone to download and install the APK directly on it.
AppJetpack
Build FlavorJalapeno
Build TypeDebug
Commitb2feee0
Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test these changes on WordPress by downloading wordpress-installable-build-pr17738-b2feee0.apk
💡 Scan this QR code with your Android phone to download and install the APK directly on it.
AppWordPress
Build FlavorJalapeno
Build TypeDebug
Commitb2feee0
Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

Copy link
Contributor

@AjeshRPai AjeshRPai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything LGTM 👍🏼

@AjeshRPai AjeshRPai merged commit 4e37f62 into trunk Jan 13, 2023
@AjeshRPai AjeshRPai deleted the issue/17339-jetpack-focus-create-page-p4 branch January 13, 2023 11:16
AjeshRPai added a commit that referenced this pull request Mar 17, 2023
Updates: the logic to remove template selection ability in
static poster phase 4

This commit is based on this commit
 b2feee0 from this PR -
 #17738
 which disabled the feature on phase 4

 Added a helper function to disable the template selection in
 pages and replaced the usages of `shouldRemoveJetpackFeatures` with
 `shouldShowTemplateSelectionInPages`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants