[GB] Do not hide Navigation bar #9311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
daniloercoli
deleted the
issue/9199-Navigation-bar-is-missing-after-image-settings
branch
|
Heh, there's actually this ticket by @iamthomasbishop wordpress-mobile/gutenberg-mobile#614 for which we could re-use the logic to hide the top bar but, we can always try to address it directly later. Beyond that, I think the logic was there before to offer more space when in landscape and since we didn't make use of the Android provided |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR "Fixes" #9199 by removing all the logic related to the show/hide the action bar.
Actually i'm not sure why we needed it, maybe someone can provide a clarification / use case when the action bar should be gone in the new GB editor?
To test:
Update release notes:
RELEASE-NOTES.txt.