Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mobile block editor to the latest #11628

Merged
merged 1 commit into from
May 3, 2019

Conversation

loremattei
Copy link
Contributor

This PR updates the gutenberg-mobile reference to point to the latest release, v1.4.0.

The reference is currently pointing to the release/1.4.0 branch on https://github.com/wordpress-mobile/gutenberg-mobile. Relevant PR: wordpress-mobile/gutenberg-mobile#951.

When that gets merged to gutenberg-mobile master, I'll update the ref here to point to the v1.4.0 tag on gutenberg-mobile master.

To test:
The block editor should work as normal.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@loremattei loremattei added the Gutenberg Editing and display of Gutenberg blocks. label May 3, 2019
@loremattei loremattei added this to the 12.4 milestone May 3, 2019
@loremattei loremattei requested a review from pinarol May 3, 2019 12:45
@koke
Copy link
Member

koke commented May 3, 2019

I think we also need a new version of react-native-aztec integrated on WPiOS, I'm not seeing the changes from wordpress-mobile/gutenberg-mobile#943 in this one

EDIT: it worked after a clean build

Copy link
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉 Tested with recent improvements and other smoke test scenarios

@loremattei loremattei force-pushed the update-gutenberg-to-1.4.0 branch from bc2014e to 70bc63c Compare May 3, 2019 15:16
@loremattei loremattei merged commit 985931b into develop May 3, 2019
@loremattei loremattei deleted the update-gutenberg-to-1.4.0 branch May 3, 2019 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants