-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gutenberg: Compatibility with React Native 0.60.0 #12056
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
jtreanor
commented
Jul 3, 2019
WordPress/Classes/ViewRelated/Gutenberg/GutenbergViewController.swift
Outdated
Show resolved
Hide resolved
jtreanor
force-pushed
the
gutenberg/rn-0-60-0
branch
from
July 3, 2019 14:43
92e14ab
to
ccbddcb
Compare
jtreanor
force-pushed
the
gutenberg/rn-0-60-0
branch
from
July 4, 2019 09:11
ccbddcb
to
19ac2bd
Compare
etoledom
approved these changes
Jul 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working great!
Tested via wordpress-mobile/gutenberg-mobile#1184 (review)
Thank you @jtreanor 🙏
Left a comment but I don't think it's a blocker for this PR. |
1 task
jtreanor
force-pushed
the
gutenberg/rn-0-60-0
branch
from
July 8, 2019 15:14
2a19172
to
24b18a3
Compare
1 task
jtreanor
added
Tooling
Build, Release, and Validation Tools
and removed
Tooling
Build, Release, and Validation Tools
labels
Jul 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gutenberg PR is here: wordpress-mobile/gutenberg-mobile#1184
To test:
Update release notes:
RELEASE-NOTES.txt
.