-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing Gutenberg after merging navigation feature #13082
Conversation
Generated by 🚫 dangerJS |
@iamthomasbishop Could you try to install the app with the peril link provided by this PR? It demonstrates how it looks after the merge of inner block enhancements. There are some things that look a bit odd to me but I can't be sure if that's intended. If you find some issues we'll need to fix those before holidays so the earlier we spot the better. |
That's right, @pinarol – the Inline Toolbar does look like it has some extra spacing – looks like not just additional bottom spacing, but also and left/right spacing (16px?): |
It is so great to see this in action – a long time coming! 😄 I have some quick feedback. EDIT: I've re-ordered based on priority and labeled those that I would consider blockers as such. Blockers
Non-blockers
That's all I've got right now, I am going to give it another spin tomorrow morning 😄 Thanks for all of the hard work on this thus far! |
@pinarol @lukewalczak Updated my last comment to include which I think are blockers vs. non-blockers and roughly sorted by priority. |
Fixes #
To test:
PR submission checklist:
I have considered adding unit tests where possible.
I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txt
if necessary.