Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix testBasicPostPublish UI Test #16422

Merged

Conversation

illusaen
Copy link
Contributor

@illusaen illusaen commented May 1, 2021

UI test EditorGutenbergTests-testBasicPostPublish was breaking because test was trying to tap image block after adding it to pop up the bottom sheet, whereas now the bottom sheet seems to pop up automatically after adding the block. Fixed by removing the tap (this is the only test that uses that function).

To test:
Run all UI tests

SS

Screen Shot 2021-04-30 at 6 58 31 PM

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

…aks UI test that is trying to select image block. Fixed this by removing the image block tap.
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 1, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

You can trigger an installable build for these changes by visiting CircleCI here.

@illusaen illusaen requested a review from cameronvoell May 1, 2021 00:03
@illusaen illusaen added the Testing Unit and UI Tests and Tooling label May 1, 2021
@illusaen illusaen added this to the 17.3 milestone May 1, 2021
Copy link
Contributor

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and for troubleshooting this issue! 🙇

@cameronvoell cameronvoell merged commit 6e88eb1 into gutenberg/integrate_release_1.52.0 May 1, 2021
@cameronvoell cameronvoell deleted the fix-ui-tests-1.52.0 branch May 1, 2021 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing Unit and UI Tests and Tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants