Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove personalizing dashboard from release notes #20483

Merged
merged 2 commits into from
Apr 6, 2023
Merged

Remove personalizing dashboard from release notes #20483

merged 2 commits into from
Apr 6, 2023

Conversation

guarani
Copy link
Contributor

@guarani guarani commented Apr 5, 2023 •
edited
Loading

@Gio2018, today @tiagomar called attention to the personalize dashboard release notes in 22.1. This feature is still a work-in-progress, so this shouldn't be in 22.1's release notes. Instead we can add it back once we're confident which release this will ship in.

Related Slack discussion to remove this from the final release notes: p1680719118039509/1680571332.933819-slack-C02S5P5MBGA

Regression Notes

  1. Potential unintended areas of impact

Non-code change, no risk.

  1. What I did to test those areas of impact (or what existing automated tests I relied on)

Non-code change, no testing required.

  1. What automated tests I added (or what prevented me from doing so)

Non-code change, automated testing not applicable.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

Warnings
⚠️ The AppStoreStrings.po file must be updated any time changes are made to release notes

Generated by 🚫 dangerJS

@guarani guarani marked this pull request as ready for review April 5, 2023 18:27
@guarani guarani requested a review from mokagio April 5, 2023 18:27
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr20483-31f7857
Version22.1
Bundle IDorg.wordpress.alpha
Commit31f7857
App Center BuildWPiOS - One-Offs #5420
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr20483-31f7857
Version22.1
Bundle IDcom.jetpack.alpha
Commit31f7857
App Center Buildjetpack-installable-builds #4449
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

mokagio
mokagio approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@mokagio mokagio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, this change did reach editorial even though it's not in the release branch.

See also #20484 where the Jetpack release notes are empty.

@mokagio mokagio merged commit 25d60ca into trunk Apr 6, 2023
@mokagio mokagio deleted the fix/release-notes-for-personalizing-dashboard branch April 6, 2023 03:09
mokagio added a commit that referenced this pull request Apr 13, 2023
@mokagio
Merge 'origin/trunk' into merge/release-22.1.0.2-into-trunk
011c8c3 
There were conflicts on `Podfile` and `Podfile.lock` because
`release/22.1` and `trunk` both changed the Gutenberg version.

As usual, I resolved them with `git checkout --theirs`, keeping the
value from `trunk` under the assumption that the latest version of
Gutenberg, 1.93.0-alpha2, is what `trunk` needs to work and that if the
1.92.1 hotfix hasn't already been integrated in the latest release, it
will be soon and the Gutenberg team will followup with a new version
update on `trunk`.

There was also a conflict on the `RELEASE-NOTES.txt` that GitHub picked
up with its more refined conflicts engine and that auto-merge didn't
address properly but that I manually fixed.

That was due to `release/22.1` adding new release note entries – which
will not make it into the App Store release notes – in the 22.1 section
and `trunk` having #20128 editing that section, too. #20128 was meant to
land on `release/22.1` but I forgot to update the base branch after
starting the code freeze 🤦‍♂️😭

Also, the entry about the personalize home tab had been removed on
`trunk` via ec8a377. The release notes
editor was notified about it,
#20483 (review)

```
<<<<<<< release/22.1 -- Incoming Change
* [**] Add a "Personalize Home Tab" button to the bottom of the Home tab that allows changing cards visibility. [#20369]
* [*] [Reader] Fix an issue that was causing the app to crash when tapping the More or Share buttons in Reader Detail screen. [#20490]
* [*] Block editor: Avoid empty Gallery block error [WordPress/gutenberg#49557]
=======
* [**] [internal] Refactored Google SignIn implementation to not use the Google SDK [#20128]
>>>>>>> trunk -- Current Change
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mokagio mokagio mokagio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guarani @wpmobilebot @mokagio