Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Fix undo/redo history when inserting a link configured to open in a new tab #20661

Closed
wants to merge 4 commits into from

Conversation

derekblank
Copy link
Contributor

Test for wordpress-mobile/gutenberg-mobile#5747. Do not merge.

Fixes #

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 11, 2023

Fails
🚫 Podfile: reference to a commit hash for Gutenberg,RNTAztecView

Generated by 🚫 dangerJS

@@ -11,8 +11,8 @@
#
# LOCAL_GUTENBERG=../my-gutenberg-fork bundle exec pod install
GUTENBERG_CONFIG = {
# commit: '',
tag: 'v1.94.0'
commit: '106f3ddfaf047199256ce5c521b738f382a9026b',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 Avoid comma after the last item of a hash.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 11, 2023

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr20661-b5c260e
Version22.3
Bundle IDcom.jetpack.alpha
Commitb5c260e
App Center Buildjetpack-installable-builds #4738
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 11, 2023

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr20661-b5c260e
Version22.3
Bundle IDorg.wordpress.alpha
Commitb5c260e
App Center BuildWPiOS - One-Offs #5708
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@derekblank derekblank closed this Jul 31, 2023
@jkmassel jkmassel deleted the gutenberg/fix-undo-redo-history branch July 26, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants