Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gutenberg] - Gallery block - Fix getMediaItems #23417

Conversation

geriux
Copy link
Contributor

@geriux geriux commented Jul 11, 2024

Related PRs:

Fixes an issue with the Gallery block displaying an invalid type error when adding images.

To Test:

Check the Gutenberg PR description.

Regression Notes

  1. Potential unintended areas of impact

It affects only the editor.

  1. What I did to test those areas of impact (or what existing automated tests I relied on)

Manual testing.

  1. What automated tests I added (or what prevented me from doing so)

No new tests were added.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@geriux geriux added the Gutenberg Editing and display of Gutenberg blocks. label Jul 11, 2024
@geriux geriux added this to the 25.2 milestone Jul 11, 2024
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jul 11, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23417-2fbdf50
Version25.1
Bundle IDorg.wordpress.alpha
Commit2fbdf50
App Center BuildWPiOS - One-Offs #10285
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jul 11, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23417-2fbdf50
Version25.1
Bundle IDcom.jetpack.alpha
Commit2fbdf50
App Center Buildjetpack-installable-builds #9332
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@geriux geriux merged commit acdcc18 into gutenberg/remove-gallery-v1-and-experimental-flags Jul 12, 2024
24 checks passed
@geriux geriux deleted the gutenberg/fix-api-fetch-json-response branch July 12, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants