Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Quote] Tapping return at end of block doesn't create new block #1104

Closed
iamthomasbishop opened this issue Jun 7, 2019 · 3 comments
Closed
Assignees
Labels
HACK week HACK week June 2020 [Type] Bug Something isn't working
Milestone

Comments

@iamthomasbishop
Copy link
Contributor

Note: I'm running a custom version of WPiOS, built off of develop (iOS 12.4, iPhone Xs Max). I haven't tried a build w/ Quote on Android yet.

Steps to reproduce

  • Select a Quote block with some text
  • Go to end of block's contents
  • Tap enter

Expected Behavior

I expect a new block to be created, just like happens on other RichText blocks.

@iamthomasbishop iamthomasbishop added the [Type] Bug Something isn't working label Jun 7, 2019
@SergioEstevao
Copy link
Contributor

@iamthomasbishop this is not the way GB web work. We will need to open a ticket there if we want to change this behaviour.

@iamthomasbishop
Copy link
Contributor Author

Fair enough. I think it's worth doing, but maybe not urgent.

Also, maybe this is only at the end of the citation field - if you have a quote but no citation, tapping return should continue to the citation field. Then another return in the citation would create a new block.

@hypest hypest added the HACK week HACK week June 2020 label Jun 7, 2020
@SergioEstevao SergioEstevao self-assigned this Jun 9, 2020
@SergioEstevao
Copy link
Contributor

Fixed by this PR: #2352

@SergioEstevao SergioEstevao added this to the 1.30 milestone Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HACK week HACK week June 2020 [Type] Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants