Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/426 fix enter on captions #2352

Merged
merged 10 commits into from
Jun 8, 2020
Merged

Issue/426 fix enter on captions #2352

merged 10 commits into from
Jun 8, 2020

Conversation

SergioEstevao
Copy link
Contributor

Fixes #426

To test:

  • Start the demo app
  • Add an image block
  • Set an image to it
  • Add a caption
  • When writing on the caption tap Enter on the end of the caption text
  • Check if new paragraph block is inserted
  • Do the same test as above using a video block.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@SergioEstevao SergioEstevao added this to the 1.30 milestone Jun 5, 2020
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 5, 2020 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@SergioEstevao SergioEstevao mentioned this pull request Jun 5, 2020
Merged
6 tasks
@mchowning
Copy link
Contributor

mchowning commented Jun 5, 2020 •
edited
Loading

I'm seeing an issue with this on Android only where pressing Enter both creates a new paragraph block and adds a <br> to the caption. I've looked into it a bit, but I haven't figured out yet what is causing this. I believe this is fixed with WordPress/gutenberg@4c35926, which I added to the gb-side PR.

mchowning
mchowning approved these changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested via WordPress/gutenberg#22928 and looks good! 👍

@SergioEstevao SergioEstevao merged commit 7495fbf into develop Jun 8, 2020
@SergioEstevao SergioEstevao deleted the issue/426_fix_enter_on_captions branch June 8, 2020 21:56
@SergioEstevao SergioEstevao mentioned this pull request Jun 9, 2020
Closed
@hypest
Copy link
Contributor

hypest commented Jun 11, 2020

Is this also fixing #1651?

@mchowning mchowning mentioned this pull request Jun 11, 2020
Closed
@mchowning
Copy link
Contributor

Is this also fixing #1651

👍 Closed the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchowning mchowning mchowning approved these changes

@etoledom etoledom Awaiting requested review from etoledom

Assignees
No one assigned
Labels
Media Writing Flow
Projects
None yet
Milestone
1.30
Development

Successfully merging this pull request may close these issues.

Proposal: add a new default block (para) when tapping Enter on Image caption
3 participants
@SergioEstevao @mchowning @hypest