Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Multiple media selection adds only one image/video block #1346

Closed
pinarol opened this issue Sep 3, 2019 · 1 comment · Fixed by #1383
Closed

[Android] Multiple media selection adds only one image/video block #1346

pinarol opened this issue Sep 3, 2019 · 1 comment · Fixed by #1383
Assignees
Labels
[OS] Android [Type] Bug Something isn't working

Comments

@pinarol
Copy link
Contributor

pinarol commented Sep 3, 2019

Current behavior:

  • Add an image/video block
  • Add multiple images/videos from WordPress media library
  • Only 1 image/video block is added

Expected behavior:

  • Add an image/video block
  • Add multiple images/videos from WordPress media library
  • Multiple image/video blocks are added with the selected images/videos

Root cause analysis

It looks like we are having a side effect of a recently merged PR. The code that subscribes for mediaAppend events are moved and since inserter menu is not rendered after we pick the media it won't be able to listen. We can try moving this subscription back to its old place as a solution, or anywhere more suitable which won't be unmounted along the way.

This is only observable via WordPress Android app because WordPress iOS app doesn't let multiple selection on WordPress media library currently.

@pinarol pinarol added [Type] Bug Something isn't working [OS] Android labels Sep 3, 2019
@pinarol pinarol changed the title [Android] Multiple media selection adds only one image block [Android] Multiple media selection adds only one image/video block Sep 3, 2019
@etoledom
Copy link
Contributor

etoledom commented Sep 3, 2019

This also seems to be the cause of an issue on WPiOS, where the Force Touch app shortcut doesn't work properly selecting "New Photo Post".

Steps:

  • Force Touch on the WPiOS app icon.
  • Select New Photo Post shortcut.
  • Make sure Gutenberg was opened as the editor.
  • Select an Image.
  • 💥 No image block was appended.

Force_touch_bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[OS] Android [Type] Bug Something isn't working
Projects
None yet
3 participants