Fix when multiple media selection adds only one image or video block #1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Point to appropriate gb ref
marecar3
changed the title
5 tasks
…only-one-image-or-video-block # Conflicts: # gutenberg
|
Hey, in my PR I added the possibility to select how we will handle the multiple select. If multiple is set to false - we will use the old implementation and few blocks with image/video should be added by sending event through the bridge. If multiple is set to true, all selected media will be passed to the JS callback instead of sending them in event one by one. |
…only-one-image-or-video-block # Conflicts: # gutenberg
etoledom
approved these changes
Oct 2, 2019
There was a problem hiding this comment.
Looks good! Approved via WordPress/gutenberg#17579 (review)
I added a comment on the release notes. I think we should specify the platform on these fixes.
|
Milestone moved to 1.15 |
…only-one-image-or-video-block
marecar3
deleted the
issue/1346_Multiple-media-selection-adds-only-one-image-or-video-block
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1346 . Additional details and testing instructions are in the description of the related gutenberg PR.
Update release notes:
RELEASE-NOTES.txt.