Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Caption component to make it available for Gallery tiles #1639

Closed
pinarol opened this issue Nov 29, 2019 · 4 comments
Closed

Refactor Caption component to make it available for Gallery tiles #1639

pinarol opened this issue Nov 29, 2019 · 4 comments
Assignees

Comments

@pinarol
Copy link
Contributor

pinarol commented Nov 29, 2019

We have a Caption component used by Image, Video blocks but it is assuming that Caption is put on block level. So we weren't able to use it from Gallery tiles. Let's divide that component into 2 and make the UI part available for individual tiles of Gallery.

In theory we can rename the current one as BlockCaption and extract the UI part into a component named Caption. Image, Video blocks can use BlockCaption while tiles use Caption.

Otherwise we'll need to duplicate fixes like this in gallery tiles.

@pinarol
Copy link
Contributor Author

pinarol commented Nov 29, 2019

@geriux Gallery PRs aren't merged yet, so we are using this PR's branch to test it. You can collaborate with @mkevins about Gallery.

@iamthomasbishop
Copy link
Contributor

@pinarol would it make sense to solve this issue (wordpress-mobile/WordPress-iOS#13063) on our end GB while we are doing this refactoring of the caption component? Or is it better solved at the Aztec level?

// hat tip @designsimply for finding the issue! Perhaps also related to this one? #1609

@pinarol
Copy link
Contributor Author

pinarol commented Dec 13, 2019

🧐 That looks like a very different issue which will require us to touch different parts of the code. So better be handled separately. @iamthomasbishop

@iamthomasbishop
Copy link
Contributor

Ok, fair enough. Thanks for confirming!

@pinarol pinarol closed this as completed Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants