Refactor Caption Component #1678
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 12, 2019 16:39
6 tasks
added 3 commits
December 18, 2019 11:17
…e into refactor/caption-block # Conflicts: # gutenberg
…e into refactor/caption-block # Conflicts: # gutenberg
mkevins
approved these changes
Jan 7, 2020
There was a problem hiding this comment.
Tested via steps described here: WordPress/gutenberg#19118
I had to locally merge with latest (gutenberg:master and gutenberg-mobile:develop) to the respective branches for these PRs due to an intermittent dependency issue, but after that, everything is working nicely. Nice work @geriux 👍 . After updating to latest, LGTM!
|
Closing since this merged PR #1771 updates the same Gutenberg reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1639
GutenbergPR -> WordPress/gutenberg#19118To test:
Check the
GutenbergPRUpdate release notes:
RELEASE-NOTES.txt.