Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Border of Title is Against the Edge of the Screen #2258

Closed
mchowning opened this issue May 13, 2020 · 1 comment · Fixed by WordPress/gutenberg#22331
Closed

Border of Title is Against the Edge of the Screen #2258

mchowning opened this issue May 13, 2020 · 1 comment · Fixed by WordPress/gutenberg#22331
Assignees
Labels
[Pri] High [Type] Bug Something isn't working
Milestone

Comments

@mchowning
Copy link
Contributor

Describe the bug
Border around title when selected is against the edge of the screen

To Reproduce
Steps to reproduce the behavior:

  1. Go to a post and select the title
  2. Observe that the border is against the edge of the screen

Expected behavior
The border should not be against the edge of the screen.

Screenshots

image (2)

Smartphone (please complete the following information):

  • Device: Pixel, iPhone Xr
  • OS: Android X, iOS 13.4.1
  • 4beb166

Additional context
It appears this regression was introduced since the 1.27 release.

@mchowning mchowning added [Type] Bug Something isn't working [Pri] High labels May 13, 2020
@mchowning mchowning added this to the 1.28 milestone May 13, 2020
@mchowning
Copy link
Contributor Author

Per @iamthomasbishop on Slack:

Depending on if the border is on inside or outside, it would either be 3px or 4px margin on left/right of the block border 1nd 12px or 13px padding on the inside of the border (on left/right). So the text should line up to the 16px key line. 3px margin, 1px border, 12px padding...IIRC

Related to #2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Pri] High [Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants