Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix margin for the post-title #22331

Merged
merged 3 commits into from
May 13, 2020
Merged

Conversation

SergioEstevao
Copy link
Contributor

Add 4px margin from the edges of the screen and adjust the alignment
of text.

Description

Fixes: wordpress-mobile/gutenberg-mobile#2258

Adjust post title margins in RN mobile

How has this been tested?

Screenshots

Screenshot 2020-05-13 at 19 18 17

Types of changes

Visual adjustment.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

Add 4px margin from the edges of the screen and adjust the alignment
of text.
@SergioEstevao SergioEstevao added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label May 13, 2020
@github-actions
Copy link

github-actions bot commented May 13, 2020

Size Change: +230 B (0%)

Total Size: 833 kB

Filename Size Change
build/block-editor/index.js 104 kB -1 B
build/block-library/index.js 118 kB +3 B (0%)
build/components/index.js 182 kB +2 B (0%)
build/edit-post/index.js 28.2 kB +144 B (0%)
build/edit-site/index.js 12 kB -21 B (0%)
build/edit-widgets/index.js 8.47 kB +103 B (1%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.02 kB 0 B
build/annotations/index.js 3.62 kB 0 B
build/api-fetch/index.js 3.39 kB 0 B
build/autop/index.js 2.83 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 6.59 kB 0 B
build/block-directory/style-rtl.css 764 B 0 B
build/block-directory/style.css 764 B 0 B
build/block-editor/style-rtl.css 10.8 kB 0 B
build/block-editor/style.css 10.8 kB 0 B
build/block-library/editor-rtl.css 7.25 kB 0 B
build/block-library/editor.css 7.25 kB 0 B
build/block-library/style-rtl.css 7.48 kB 0 B
build/block-library/style.css 7.49 kB 0 B
build/block-library/theme-rtl.css 683 B 0 B
build/block-library/theme.css 685 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 48.1 kB 0 B
build/components/style-rtl.css 17.1 kB 0 B
build/components/style.css 17 kB 0 B
build/compose/index.js 6.68 kB 0 B
build/core-data/index.js 11.4 kB 0 B
build/data-controls/index.js 1.29 kB 0 B
build/data/index.js 8.43 kB 0 B
build/date/index.js 5.47 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 3.1 kB 0 B
build/edit-navigation/index.js 5.6 kB 0 B
build/edit-navigation/style-rtl.css 618 B 0 B
build/edit-navigation/style.css 617 B 0 B
build/edit-post/style-rtl.css 12.2 kB 0 B
build/edit-post/style.css 12.2 kB 0 B
build/edit-site/style-rtl.css 5.22 kB 0 B
build/edit-site/style.css 5.22 kB 0 B
build/edit-widgets/style-rtl.css 4.69 kB 0 B
build/edit-widgets/style.css 4.69 kB 0 B
build/editor/editor-styles-rtl.css 425 B 0 B
build/editor/editor-styles.css 428 B 0 B
build/editor/index.js 44.3 kB 0 B
build/editor/style-rtl.css 5.07 kB 0 B
build/editor/style.css 5.08 kB 0 B
build/element/index.js 4.65 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.63 kB 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/hooks/index.js 2.13 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.56 kB 0 B
build/is-shallow-equal/index.js 712 B 0 B
build/keyboard-shortcuts/index.js 2.51 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/index.js 3.13 kB 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/media-utils/index.js 5.29 kB 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/index.js 3.4 kB 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/primitives/index.js 1.5 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/rich-text/index.js 14.8 kB 0 B
build/server-side-render/index.js 2.68 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.28 kB 0 B
build/url/index.js 4.02 kB 0 B
build/viewport/index.js 1.84 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.18 kB 0 B

compressed-size-action

@mchowning
Copy link
Contributor

The sides look good to me, but the vertical spacing above the title seems to gotten reduced quite a bit too, which is surprising given the changes. iOS is showing the same loss of spacing above the title for me.

9699f4f 7320fd7
Screen Shot 2020-05-13 at 4 47 14 PM Screen Shot 2020-05-13 at 4 47 00 PM

@SergioEstevao
Copy link
Contributor Author

SergioEstevao commented May 13, 2020

@mchowning just updated the PR to only add horizontal margins.

Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @SergioEstevao !

@SergioEstevao SergioEstevao merged commit 8f92709 into master May 13, 2020
@SergioEstevao SergioEstevao deleted the rnmobile/fix_post_title_margins branch May 13, 2020 22:32
@github-actions github-actions bot added this to the Gutenberg 8.2 milestone May 13, 2020
SergioEstevao added a commit that referenced this pull request May 13, 2020
* Fix margin for the post-title

Add 4px margin from the edges of the screen and adjust the alignment
of text.

* Only apply margins on the left and right edges.
mchowning added a commit that referenced this pull request May 26, 2020
* RNMobile - Starter Page Templates - Portfolio: adds missing ids for galleries (#22321)

* Fix margin for the post-title (#22331)

* Fix margin for the post-title

Add 4px margin from the edges of the screen and adjust the alignment
of text.

* Only apply margins on the left and right edges.

* Correct buttons appender (#22362)

* Remove no longer necessary selection checks (#22500)

These are now handled on the native side

Co-authored-by: Gerardo Pacheco <gerardo.pacheco@automattic.com>
Co-authored-by: Sérgio Estêvão <sergioestevao@gmail.com>
Co-authored-by: Luke Walczak <lukasz.walczak.pwr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Border of Title is Against the Edge of the Screen
2 participants