Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button: Toolbar goes up and down for a split second when dismissing settings #2301

Closed
pinarol opened this issue May 22, 2020 · 1 comment · Fixed by WordPress/gutenberg#23684, WordPress/gutenberg#24414 or #2596
Closed

Button: Toolbar goes up and down for a split second when dismissing settings #2301

pinarol opened this issue May 22, 2020 · 1 comment · Fixed by WordPress/gutenberg#23684, WordPress/gutenberg#24414 or #2596
Assignees
@lukewalczak
Labels
[Pri] Low [Type] Bug Something isn't working

Comments

@pinarol
Copy link
Contributor

pinarol commented May 22, 2020

To Reproduce

  1. Add a Button
  2. Click on Button block settings
  3. Focus on URL field
  4. Close the Bottom sheet by tapping outside of it

Result: Toolbar goes up and down detaching from the keyboard for a split second

Expected behavior
Toolbar stays on the keyboard

Screenshots

May-22-2020 12-48-08

Smartphone (please complete the following information):

  • Device: iPhoneXS
  • OS: iOS 13
  • Version WordPress iOS 14.8
@pinarol pinarol added [Type] Bug Something isn't working [Pri] Low labels May 22, 2020
@lukewalczak lukewalczak self-assigned this Jul 1, 2020
@pinarol pinarol mentioned this issue Jul 21, 2020
Merged
6 tasks
@chipsnyder
Copy link
Contributor

Discovered an error as part of the original fix for this. Reverted the original change here (WordPress/gutenberg#24388) and reopening to re investigate.

@chipsnyder chipsnyder reopened this Aug 5, 2020
@lukewalczak lukewalczak mentioned this issue Aug 6, 2020
Merged
6 tasks
@lukewalczak lukewalczak mentioned this issue Sep 4, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukewalczak lukewalczak

Labels
[Pri] Low [Type] Bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@chipsnyder @pinarol @lukewalczak