Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[RNMobile] Fix jumping toolbar" #24388

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

chipsnyder
Copy link
Contributor

@chipsnyder chipsnyder commented Aug 5, 2020

Reverts #23684

This PR reverts the changes in #23684 due to an error that was being generated while trying to layout the Starter Page Template buttons and the bottom bar.

Screen Shot 2020-08-05 at 11 05 52 AM

After Revert:

Screen Shot 2020-08-05 at 1 38 58 PM

@chipsnyder chipsnyder added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Aug 5, 2020
@chipsnyder chipsnyder requested review from geriux and removed request for pinarol August 5, 2020 17:21
@github-actions
Copy link

github-actions bot commented Aug 5, 2020

Size Change: 0 B

Total Size: 1.16 MB

ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.67 kB 0 B
build/api-fetch/index.js 3.44 kB 0 B
build/autop/index.js 2.82 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 7.97 kB 0 B
build/block-directory/style-rtl.css 953 B 0 B
build/block-directory/style.css 952 B 0 B
build/block-editor/index.js 125 kB 0 B
build/block-editor/style-rtl.css 10.8 kB 0 B
build/block-editor/style.css 10.8 kB 0 B
build/block-library/editor-rtl.css 7.59 kB 0 B
build/block-library/editor.css 7.59 kB 0 B
build/block-library/index.js 132 kB 0 B
build/block-library/style-rtl.css 7.76 kB 0 B
build/block-library/style.css 7.77 kB 0 B
build/block-library/theme-rtl.css 728 B 0 B
build/block-library/theme.css 729 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 48.3 kB 0 B
build/components/index.js 200 kB 0 B
build/components/style-rtl.css 15.7 kB 0 B
build/components/style.css 15.7 kB 0 B
build/compose/index.js 9.68 kB 0 B
build/core-data/index.js 11.8 kB 0 B
build/data-controls/index.js 1.29 kB 0 B
build/data/index.js 8.45 kB 0 B
build/date/index.js 5.38 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 3.23 kB 0 B
build/edit-navigation/index.js 10.9 kB 0 B
build/edit-navigation/style-rtl.css 1.08 kB 0 B
build/edit-navigation/style.css 1.08 kB 0 B
build/edit-post/index.js 304 kB 0 B
build/edit-post/style-rtl.css 5.61 kB 0 B
build/edit-post/style.css 5.61 kB 0 B
build/edit-site/index.js 17 kB 0 B
build/edit-site/style-rtl.css 3.06 kB 0 B
build/edit-site/style.css 3.06 kB 0 B
build/edit-widgets/index.js 9.38 kB 0 B
build/edit-widgets/style-rtl.css 2.45 kB 0 B
build/edit-widgets/style.css 2.45 kB 0 B
build/editor/editor-styles-rtl.css 537 B 0 B
build/editor/editor-styles.css 539 B 0 B
build/editor/index.js 45.3 kB 0 B
build/editor/style-rtl.css 3.8 kB 0 B
build/editor/style.css 3.79 kB 0 B
build/element/index.js 4.65 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.72 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 2.13 kB 0 B
build/html-entities/index.js 621 B 0 B
build/i18n/index.js 3.56 kB 0 B
build/is-shallow-equal/index.js 711 B 0 B
build/keyboard-shortcuts/index.js 2.52 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/index.js 3.11 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.33 kB 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/index.js 3.4 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/primitives/index.js 1.41 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/rich-text/index.js 13.9 kB 0 B
build/server-side-render/index.js 2.71 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.85 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

@lukewalczak
Copy link
Member

Sorry, about that :(. Let's revert it for now, to not block the release and I will investigate it tomorrow ✌️

@chipsnyder chipsnyder marked this pull request as ready for review August 5, 2020 17:39
@chipsnyder
Copy link
Contributor Author

Thanks @lukewalczak! I was just getting ready to ping you on this as well on some convo from a side discussion but we were thinking along those same lines that you suggested.

Just tested this on my devices and it's working fine with the revert and is ready for review.

cc @geriux

Also, cc @ceyhun when this merges can we pull it into wordpress-mobile/gutenberg-mobile#2529?

Copy link
Member

@lukewalczak lukewalczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that reverting the PR fixes the issue!

@chipsnyder chipsnyder merged commit 508f920 into master Aug 5, 2020
@chipsnyder chipsnyder deleted the revert-23684-rnmobile/fix-jumping-toolbar branch August 5, 2020 18:20
@github-actions github-actions bot added this to the Gutenberg 8.8 milestone Aug 5, 2020
@pinarol
Copy link
Contributor

pinarol commented Aug 5, 2020

Thank you all @chipsnyder @lukewalczak @geriux !

ceyhun pushed a commit that referenced this pull request Aug 6, 2020
ceyhun added a commit to wordpress-mobile/gutenberg-mobile that referenced this pull request Aug 6, 2020
cameronvoell added a commit that referenced this pull request Aug 11, 2020
* Release script: Update react-native-editor version to 1.34.0

* [RNMobile] E2E Android - Use swipe gesture to scroll inserter menu (#24338)

* Set autosaveInterval to 1 on mobile (#24353)

* Revert "[RNMobile] Fix jumping toolbar (#23684)" (#24388)

This reverts commit d86cd5f.

* Turn off autosave interval for mobile (#24415)

* [RNMobile] Merge release 1.33.1 to master (#24448)

* Release script: Update react-native-editor version to 1.33.0

* Update release notes.

* Update version numbers for packages.

* Revert "Reduce spacing between label and slider control (#23580)" (#24109)

This reverts commit 2a67de0.

* Release script: Update react-native-* versions to 1.33.1

* Release script: Update with changes from 'npm run core preios'

* Allow @ char in posts in mobile editor (#24428)

This fixes a bug with the @-mention feature on mobile that made entering the standalone @ character difficult because of the @-mention UI getting in the way.
The fix here is to allow the @ character to be intercepted without being consumed by the @ key event logic.

* Remove duplicate entry from changelog

Co-authored-by: Sergio Estevao <sergioestevao@gmail.com>
Co-authored-by: Antonis Lilis <antonis.lilis@gmail.com>
Co-authored-by: Ceyhun Ozugur <ceyhunozugur@gmail.com>
Co-authored-by: Paul Von Schrottky <paul.von.schrottky@automattic.com>

* Update version numbers

* Ran pod install to update podfile.lock

Co-authored-by: Drapich Piotr <drapich.piotr@gmail.com>
Co-authored-by: Adam Zielinski <adam@adamziel.com>
Co-authored-by: Chip <chip.snyder3@gmail.com>
Co-authored-by: Cameron Voell <cameronvoell@gmail.com>
Co-authored-by: Sergio Estevao <sergioestevao@gmail.com>
Co-authored-by: Antonis Lilis <antonis.lilis@gmail.com>
Co-authored-by: Paul Von Schrottky <paul.von.schrottky@automattic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants