-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deleting suggestion trigger character doesn't remove character from post #2943
Comments
This might be desirable behavior. If we removed the character when you backed out of the suggestions UI, I'm not sure there would be a good way to just add the @ character if that was what you wanted (i.e., because every time you tried to enter the character you would get the suggestions UI, and backing out of the suggestions UI would remove the character you just tried to enter). cc: @iamthomasbishop |
@guarani Thanks for surfacing this! I think it's great that we allow spaces in the middle of the query, so I'd prefer not to lose that ability, but it might be a good idea (as you mentioned) to hide the UI when a space is typed immediately after the In terms of the stray Does that all make sense, or am I missing something? |
Sorry for the late reply @iamthomasbishop.
Sounds good. This will be fixed once WordPress/gutenberg#24425 is closed.
I agree with you that leaving things as-is makes it easier for users whose aim is to type a Given this, we could: I favor (a) because bringing the suggestions UI up after closing it isn't what most users will do I suspect, and I don't have a good solution to fix it without making it harder for users to add Wdyt @iamthomasbishop? |
That sounds good, let's roll with your suggestion here @guarani |
Sounds good @iamthomasbishop! I'm closing this issue as won't-fix as agreed upon in the above comments. |
Describe the bug
After typing
+
or@
in Gutenberg to trigger the suggestions UI, backspacing only deletes the symbol from the suggestions input field, and fails to delete the character from the post content itself.To Reproduce
Steps to reproduce the behavior:
+
or@
in a Paragraph block to trigger the suggestions UI+
or@
) is deleted from the suggestions input field, it's not deleted from the postExpected behavior
Tapping backspace should delete the trigger character (
+
or@
) from both the suggestions input as well as the editor post content.Screenshots
If applicable, add screenshots to help explain your problem.
Smartphone (please complete the following information):
Additional context
First reported in wordpress-mobile/WordPress-iOS#15562 (review).
The text was updated successfully, but these errors were encountered: