-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React Native: @-mentions UI impedes use of @ character in posts #24425
Comments
Fixed with #24428 and wordpress-mobile/WordPress-iOS#14598 |
@hypest I hadn't closed this because there's one aspect of this ticket which isn't fixed yet:
In discussions with @iamthomasbishop, we agreed that this appears to be a common interaction for dismissing mentions lists. I'll reopen this to ensure we don't lose track of this, just let me know if you think otherwise 👍 |
Fine by me either way @guarani , sorry I closed the ticket... I thought that the issue is actually now fixed and we are only looking at adding more ways to dismiss the UI. |
No worries, and thanks for looking out for un-closed issues! |
I like this very much because it's the least disruptive to the writing flow. |
Users expect the suggestions UI to be dismissed when typing a space immediately after a trigger character (e.g. `@` for mentions, `+` for cross-posts). Addresses WordPress/gutenberg#24425 (for iOS)
The fix for iOS has been merged, WPAndroid will need the same change to dismiss the suggestion UI when typing |
For clarity, @SiobhyB is working on the Android side of the fix. |
I forgot to update that the Android side of this was merged with wordpress-mobile/WordPress-Android#14793. @guarani, are there any other pending parts to this, or are we all set to close this issue? |
Thanks for the ping and sorry for the late reply. I agree it can be closed and I'll go ahead and close the issue now. |
Describe the bug
With the implementation of the @-mentions feature on mobile, it became difficult to type an @ character without making it a mention.
Ideally, the user should be able to add the @ character using any of these approaches:
a. tap backspace after adding a @ character, which should dismiss the mentions UI and leave the @ character in the post
b. tap outside the mentions UI to dismiss it and leave the @ character in the post
c. tap space after adding a @ character, which should dismiss the mentions UI and leave the @ character in the post
To reproduce
Steps to reproduce the behavior:
Expected behavior
Dismissing the list should leave the @ character on the post, allowing users to enter the character without using an @-mention.
Screenshots
Screen recording courtesy of @designsimply: 1m11s
Smartphone:
Additional information
For example, the user may wish to type a Twitter handle and would find that the current @-mention UI makes this difficult. Current workarounds include choosing any user from the @-mention list and then erase the username portion leaving the @ character in the post, or typing text and then an @ character (with no space in-between) and then deleting the leading text.
The text was updated successfully, but these errors were encountered: