Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Native: @-mentions UI impedes use of @ character in posts #24425

Closed
guarani opened this issue Aug 6, 2020 · 9 comments
Closed

React Native: @-mentions UI impedes use of @ character in posts #24425

guarani opened this issue Aug 6, 2020 · 9 comments
Assignees
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Bug An existing feature does not function as intended

Comments

@guarani
Copy link
Contributor

guarani commented Aug 6, 2020

Describe the bug
With the implementation of the @-mentions feature on mobile, it became difficult to type an @ character without making it a mention.

Ideally, the user should be able to add the @ character using any of these approaches:
a. tap backspace after adding a @ character, which should dismiss the mentions UI and leave the @ character in the post
b. tap outside the mentions UI to dismiss it and leave the @ character in the post
c. tap space after adding a @ character, which should dismiss the mentions UI and leave the @ character in the post

To reproduce
Steps to reproduce the behavior:

  1. Open a new post
  2. Add a paragraph or other rich-text based block
  3. Type an @ character and dismiss the list of @-mention users (tap outside the list to dismiss)
  4. Notice how the @ character is removed from the post when the list is dismissed

Expected behavior
Dismissing the list should leave the @ character on the post, allowing users to enter the character without using an @-mention.

Screenshots

Screen recording courtesy of @designsimply: 1m11s

Smartphone:

  • Device: Any iOS device
  • OS: iOS
  • Version: Any version

Additional information
For example, the user may wish to type a Twitter handle and would find that the current @-mention UI makes this difficult. Current workarounds include choosing any user from the @-mention list and then erase the username portion leaving the @ character in the post, or typing text and then an @ character (with no space in-between) and then deleting the leading text.

@guarani guarani self-assigned this Aug 6, 2020
@guarani guarani added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Aug 6, 2020
@guarani guarani changed the title Allow the @ character in posts React Native: Allow the @ character in posts Aug 6, 2020
@guarani guarani added the [Type] Bug An existing feature does not function as intended label Aug 6, 2020
@guarani guarani changed the title React Native: Allow the @ character in posts React Native: @-mentions UI impeds use of @ character in posts Aug 6, 2020
@guarani guarani changed the title React Native: @-mentions UI impeds use of @ character in posts React Native: @-mentions UI impedes use of @ character in posts Aug 7, 2020
@hypest
Copy link
Contributor

hypest commented Aug 10, 2020

Fixed with #24428 and wordpress-mobile/WordPress-iOS#14598

@hypest hypest closed this as completed Aug 10, 2020
@guarani
Copy link
Contributor Author

guarani commented Aug 10, 2020

@hypest I hadn't closed this because there's one aspect of this ticket which isn't fixed yet:

tap space after adding a @ character, which should dismiss the mentions UI and leave the @ character in the post

In discussions with @iamthomasbishop, we agreed that this appears to be a common interaction for dismissing mentions lists. I'll reopen this to ensure we don't lose track of this, just let me know if you think otherwise 👍

@guarani guarani reopened this Aug 10, 2020
@hypest
Copy link
Contributor

hypest commented Aug 10, 2020

Fine by me either way @guarani , sorry I closed the ticket... I thought that the issue is actually now fixed and we are only looking at adding more ways to dismiss the UI.

@guarani
Copy link
Contributor Author

guarani commented Aug 10, 2020

No worries, and thanks for looking out for un-closed issues!

@designsimply
Copy link
Member

In discussions with @iamthomasbishop, we agreed that this appears to be a common interaction for dismissing mentions lists. I'll reopen this to ensure we don't lose track of this, just let me know if you think otherwise 👍

I like this very much because it's the least disruptive to the writing flow.

guarani added a commit to wordpress-mobile/WordPress-iOS that referenced this issue May 31, 2021
Users expect the suggestions UI to be dismissed when typing a space immediately after a trigger character (e.g. `@` for mentions, `+` for cross-posts).

Addresses WordPress/gutenberg#24425 (for iOS)
@guarani
Copy link
Contributor Author

guarani commented Jun 3, 2021

The fix for iOS has been merged, WPAndroid will need the same change to dismiss the suggestion UI when typing @ followed immediately by a space.

@hypest
Copy link
Contributor

hypest commented Jun 8, 2021

For clarity, @SiobhyB is working on the Android side of the fix.

@SiobhyB
Copy link
Contributor

SiobhyB commented Aug 9, 2021

I forgot to update that the Android side of this was merged with wordpress-mobile/WordPress-Android#14793. @guarani, are there any other pending parts to this, or are we all set to close this issue?

@guarani
Copy link
Contributor Author

guarani commented Aug 18, 2021

I forgot to update that the Android side of this was merged with wordpress-mobile/WordPress-Android#14793. @guarani, are there any other pending parts to this, or are we all set to close this issue?

Thanks for the ping and sorry for the late reply. I agree it can be closed and I'll go ahead and close the issue now.

@guarani guarani closed this as completed Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants