Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually migrate heading block to the new syntax to avoid block validation errors #1143

Merged
merged 2 commits into from
Jun 17, 2019

Conversation

Tug
Copy link
Contributor

@Tug Tug commented Jun 17, 2019

Fixes the following errors happening since the Heading block was updated in WordPress/gutenberg#16035

Block validation: Block validation failed for `core/heading` ({name: "core/heading", save: ƒ, category: "common", attributes: {…}, title: "Heading", …}).

Content generated by `save` function:

<h2 class="has-text-align-left">Meet your new best friends, Blocks</h2>

Content retrieved from post body:

<h2 style="text-align:left">Meet your new best friends, Blocks</h2>

To test:

Boot the app locally and check that the block validation errors are no more.

Edit: Fixes #1141

@Tug Tug added the bugfix label Jun 17, 2019
@Tug Tug requested a review from SergioEstevao June 17, 2019 10:20
@Tug Tug self-assigned this Jun 17, 2019
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align init-html content with Gutenberg changes in heading block style
2 participants