-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix MaxListenersExceededWarning caused by dark-mode event emitter #1325
Conversation
@@ -6,13 +6,13 @@ commands: | |||
- restore_cache: | |||
name: Restore Yarn Cache | |||
keys: | |||
- yarn-i18n-v3-{{ .Environment.CIRCLE_JOB }}-{{ checksum "yarn.lock" }} | |||
- yarn-i18n-v4-{{ .Environment.CIRCLE_JOB }}-{{ checksum "yarn.lock" }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying to fix the UI Test CI failing by clearing cache but it didn't work.
Now that the cache folder was created, not sure if we should roll it back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you! |
This PR fixes a warning caused by RNDarkMode event emitter:
gutenberg
PR: WordPress/gutenberg#17186To test: