Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS DarkMode toolbar buttons #1357

Merged
merged 4 commits into from
Oct 3, 2019
Merged

Conversation

etoledom
Copy link
Contributor

@etoledom etoledom commented Sep 6, 2019

gutenberg PR: WordPress/gutenberg#17356

Description

This PR allow us to add different styles to DashIcons inside IconButton component depending on the the style theme (Dark/Light mode).

It also enhance the DarkMode theme for Toolbar buttons (and the toolbar separator)

With this change, is not needed to send ariaPressed prop from IconButton. This is a change that was requested long ago, (even though we still are sending it button states).

A second idea is to send styles directly to DashIcon from the Button, to avoid having to declare styles for every new class. I'm not sure if this is something we want to change though.

As always any moment is welcome!

toolbar

To test:

  • Run the example app with Xcode 11 beta
  • Check that the toolbar colors are correct on the toolbar (following the screenshots)
  • Check that the rest of the icons in the app shows properly
    • In particular the BottomSheet icons (Add link / Image settings)
  • Check that the icon Subscript is colored properly (Numbers on H1, H2, etc...)

cc @iamthomasbishop

@etoledom etoledom added [Type] Enhancement Improves a current area of the editor [OS] iOS labels Sep 6, 2019
@etoledom etoledom self-assigned this Sep 6, 2019
@etoledom etoledom requested a review from Tug September 6, 2019 07:07
Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested via gutenberg#17356 and it's working nicely!

@iamthomasbishop
Copy link
Contributor

iamthomasbishop commented Oct 2, 2019

Beyond stoked to see this! Well done @etoledom! :shipit:

@etoledom etoledom added this to the 1.15 milestone Oct 3, 2019
@etoledom etoledom merged commit 488af84 into develop Oct 3, 2019
@etoledom
Copy link
Contributor Author

etoledom commented Oct 3, 2019

Thank you!

@etoledom etoledom deleted the issue/darkmode-toolbar-buttons branch October 3, 2019 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[OS] iOS [Type] Enhancement Improves a current area of the editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants