Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update React Native to 0.61.5 #1450

Merged
merged 109 commits into from
Jan 24, 2020
Merged

Update React Native to 0.61.5 #1450

merged 109 commits into from
Jan 24, 2020

Conversation

jtreanor
Copy link
Contributor

@jtreanor jtreanor commented Oct 15, 2019

This is a draft of the first steps for upgrading the project to React Native 0.61.5

I have focussed on verifying that the CocoaPods patch for RN 0.61.x works correctly (facebook/react-native#25349). Here is what I have done so far:

  • Updated RN and associated packages in package.json.
  • Made a few small changes to get it to bundle successfully.
  • Updated bin/generate-podspecs.sh to work with the new RN version.
  • Generated the new podspecs and deleted obsolete ones.

Sister PRs:

As you can see from the failing CI, there is quite a bit more to do. However, it already successfully builds in WPiOS (see wordpress-mobile/WordPress-iOS#12699).

The biggest outstanding piece of work that I encountered is that gutenberg.xcodeproj will have to be completely overhauled to use CocoaPods. It may be helpful to follow the upgrade helper here.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

That branch has more clear commit history of what was updated from
upstream and what got manually modified.
@SergioEstevao
Copy link
Contributor

The biggest outstanding piece of work that I encountered is that gutenberg.xcodeproj will have to be completely overhauled to use CocoaPods. It may be helpful to follow the upgrade helper here.

FYI: I updated the project for this version of RN, basically and the dependencies are now added by cocapods instead of having subprojects. This mean that we now have gutenberg.xcworkspace that needs to be used instead of the .xcodeproj file.

@hypest
Copy link
Contributor

hypest commented Oct 23, 2019

👋 @SergioEstevao, perhaps you have some clue here: I get .../ios/gutenberg/MediaPickCoordinator.swift:4:8: error: cannot load module 'gutenberg' as 'Gutenberg' while trying to run yarn ios. Do we need some extra setup step perhaps?

@hypest
Copy link
Contributor

hypest commented Oct 23, 2019

Also, I'm getting a Ruby setup issue while running yarn ios:

$ yarn ios
yarn run v1.16.0
$ cd ios && (bundle check --path=vendor/bundle > /dev/null || bundle install) && bundle exec pod install
rbenv: bundle: command not found

The `bundle' command exists in these Ruby versions:
  2.3.0
  2.5.5

rbenv: bundle: command not found

The `bundle' command exists in these Ruby versions:
  2.3.0
  2.5.5

error Command failed with exit code 127.

@pinarol
Copy link
Contributor

pinarol commented Jan 10, 2020

An update on my comment: since we don't use our fork anymore we are planning do a separate PR to get that fix in.

@SergioEstevao SergioEstevao changed the title Update React Native to 0.61.2 Update React Native to 0.61.5 Jan 10, 2020
@hypest
Copy link
Contributor

hypest commented Jan 22, 2020

Found a red screen on Android:

Edit: happening on develop too

  1. Add a list block
  2. Tap on the "set bullet type to numbers" button in the toolbar
  3. 💥

screenshot-1579706673908

Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hypest
Copy link
Contributor

hypest commented Jan 24, 2020

The Android device testsuite is failing on the rotate-and-send-text test which by now is know to be "consistently" flaky so, will go ahead and finish the merge domino.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-process Testing Anything related to automated tests [Type] Enhancement Improves a current area of the editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants