-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update React Native to 0.61.5 #1450
Conversation
38f3c72
to
08e3b32
Compare
That branch has more clear commit history of what was updated from upstream and what got manually modified.
1ad25b2
to
9a58dd2
Compare
FYI: I updated the project for this version of RN, basically and the dependencies are now added by cocapods instead of having subprojects. This mean that we now have |
535469a
to
f2f5b94
Compare
👋 @SergioEstevao, perhaps you have some clue here: I get |
Also, I'm getting a Ruby setup issue while running
|
An update on my comment: since we don't use our fork anymore we are planning do a separate PR to get that fix in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The Android device testsuite is failing on the rotate-and-send-text test which by now is know to be "consistently" flaky so, will go ahead and finish the merge domino. |
This is a draft of the first steps for upgrading the project to React Native 0.61.5
I have focussed on verifying that the CocoaPods patch for RN 0.61.x works correctly (facebook/react-native#25349). Here is what I have done so far:
package.json
.bin/generate-podspecs.sh
to work with the new RN version.Sister PRs:
Point to the RN 0.61 upgrade in gutenberg-mobile WordPress-Android#10978[RNMobile] Update to RN v0.61 WordPress/gutenberg#19167[RNmobile] Upgrade to RN 0.61.5 WordPress/gutenberg#19369react-native-video
fork PR: Changes for gb mobile upgrade to rn 0.61 react-native-video#4react-native-svg
fork PR: Changes for gb mobile upgrade to rn 0.61 react-native-svg#9As you can see from the failing CI, there is quite a bit more to do. However, it already successfully builds in WPiOS (see wordpress-mobile/WordPress-iOS#12699).The biggest outstanding piece of work that I encountered is thatgutenberg.xcodeproj
will have to be completely overhauled to use CocoaPods. It may be helpful to follow the upgrade helper here.Update release notes:
RELEASE-NOTES.txt
.