Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nudge for adding tests, clearer language on the PR template #1561

Merged
merged 2 commits into from
Dec 13, 2019
Merged

Nudge for adding tests, clearer language on the PR template #1561

merged 2 commits into from
Dec 13, 2019

Conversation

hypest
Copy link
Contributor

@hypest hypest commented Nov 8, 2019

Updates the PR template to match the main WP apps:

  1. More clear language, indicating that the author needs to check the checkboxes
  2. Nudge for adding tests

Taken from https://github.com/wordpress-mobile/WordPress-Android/blob/db0bba0e3012be0a0533737ac054d74453e05a34/.github/PULL_REQUEST_TEMPLATE.md

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@hypest hypest added the Tooling label Nov 8, 2019
@hypest hypest added this to the 1.17 milestone Nov 8, 2019
@hypest hypest requested a review from maxme November 8, 2019 14:46
@hypest hypest changed the title Nudge for addins tests, clearer language on the PR template Nudge for adding tests, clearer language on the PR template Nov 11, 2019
@hypest hypest modified the milestones: 1.17, 1.19 Nov 27, 2019
maxme
maxme approved these changes Dec 13, 2019
View reviewed changes
Copy link
Contributor

@maxme maxme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, :shipit:

@maxme maxme merged commit 06b924d into develop Dec 13, 2019
@maxme maxme deleted the update-pr-template branch December 13, 2019 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxme maxme maxme approved these changes

Assignees
No one assigned
Labels
Tooling
Projects
None yet
Milestone
1.19
Development

Successfully merging this pull request may close these issues.
2 participants
@hypest @maxme