Libs forks need to use node_modules when building locally #1706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchowning
approved these changes
Dec 20, 2019
There was a problem hiding this comment.
This is working for me. 👍
I think we may be better off using resoulutionStrategy within gradle, but I don't have that ready-to-go yet, so in order to unblock the team I'm fine merging this and if I get a better solution working I can put up another PR proposing to revert this and use the other solution.
mchowning
deleted the
fix/update-forks-to-use-node_modules-for-maven-repo-when-building-as-npm-deps
branch
|
This PR got merged before the various fork PRs got merged so, will create a new PR to point to merged versions. |
2 tasks
This was referenced Jan 8, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1703, #1705
On Android, some of the npm libraries we're forking are using the Maven mirror of React Native both when building them as standalone libs (on JitPack) and when built locally as normal npm deps. That wouldn't be a problem per se but, the RN version referenced in the local builds is the "latest' (see this for example) so, when a newer version becomes available in the maven mirror it gets picked up.
We recently made available in the maven mirror some RN versions that are unfortunately incompatible with the versions expected by the forks, leading to crashes.
The versions used in local builds need to come from the local node_modules folder, and this PR brings in updates to the forks to do just that.
Related PRs:
react-native-svg: wordpress-mobile/react-native-svg#8react-native-video: wordpress-mobile/react-native-video#2react-native-slider: wordpress-mobile/react-native-slider#1To test:
Demo app should work as normal, including showing icons and videos
Pointing WPAndroid's gutenberg-mobile submodule to this PR should also work for all build modes and variants
PR submission checklist:
RELEASE-NOTES.txtif necessary.