Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Media Edit Icon] Show the media edit icon only if the block is selected #1841

Merged
merged 4 commits into from
Jan 31, 2020
Merged

[Media Edit Icon] Show the media edit icon only if the block is selected #1841

merged 4 commits into from
Jan 31, 2020

Conversation

leandroalonso
Copy link
Contributor

@leandroalonso leandroalonso commented Jan 30, 2020 •
edited
Loading

Gutenberg PR: WordPress/gutenberg#19961

To test

  • Check that the Media Edit icon matches the style of the Gallery icons
  • Check that the icon only appears when the Image block is selected

Screenshots

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@leandroalonso
Update gutenberg
1078b9e 
Points to a fork
@leandroalonso leandroalonso added [Type] Enhancement Improves a current area of the editor Media [Status] Needs Design Review Needs design review or sign-off before shipping labels Jan 30, 2020
@leandroalonso leandroalonso added this to the 1.22 milestone Jan 30, 2020
@SergioEstevao
Copy link
Contributor

@leandroalonso can you please add to the description the associated Gutenberg PR? This will make it easier to check associated changes. Thanks.

@leandroalonso
Copy link
Contributor Author

@SergioEstevao updated! Sorry about that.

etoledom
etoledom approved these changes Jan 30, 2020
View reviewed changes
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#19961 (review)

Let's wait for @iamthomasbishop's opinion 👍

Thank you for this improvement! 🎉

@leandroalonso leandroalonso mentioned this pull request Jan 30, 2020
Merged
6 tasks
@iamthomasbishop
Copy link
Contributor

Looks good! :shipit: !

@leandroalonso leandroalonso removed the [Status] Needs Design Review Needs design review or sign-off before shipping label Jan 31, 2020
@leandroalonso leandroalonso merged commit df607c0 into develop Jan 31, 2020
@leandroalonso leandroalonso deleted the issue/1583_only_show_media_edit_icon_when_block_is_selected branch January 31, 2020 14:14
This was referenced Feb 3, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etoledom etoledom etoledom approved these changes

@iamthomasbishop iamthomasbishop Awaiting requested review from iamthomasbishop

Assignees
No one assigned
Labels
Media [Type] Enhancement Improves a current area of the editor
Projects
None yet
Milestone
1.22
Development

Successfully merging this pull request may close these issues.
4 participants
@leandroalonso @SergioEstevao @iamthomasbishop @etoledom