Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Cover Block for Production #2028

Merged
merged 2 commits into from
Mar 18, 2020
Merged

Disable Cover Block for Production #2028

merged 2 commits into from
Mar 18, 2020

Conversation

geriux
Copy link
Contributor

@geriux geriux commented Mar 17, 2020

Gutenberg PR -> WordPress/gutenberg#20965

The dev flag was accidentally removed, this PR adds it again until is ready.

To test check Gutenberg's PR description.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@geriux geriux added the Blocks label Mar 17, 2020
@geriux geriux requested a review from pinarol March 17, 2020 16:45
pinarol
pinarol approved these changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geriux geriux merged commit 25b57fe into develop Mar 18, 2020
@geriux geriux deleted the fix/cover-block-dev-only branch March 18, 2020 07:33
@geriux geriux added this to the 1.24 milestone Mar 19, 2020
@marecar3 marecar3 mentioned this pull request Mar 19, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinarol pinarol pinarol approved these changes

Assignees
No one assigned
Labels
Blocks
Projects
None yet
Milestone
1.24
Development

Successfully merging this pull request may close these issues.
2 participants
@geriux @pinarol