-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update react-native-video dependency to remove Apache 2.0 dependencies #2124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine on iOS. On android, I don't think it is making anything worse than it already is.
However, on Android if I add a video block, a media + text block, and cover block in one article, and add one 818kb, 1 second mp4 video taken with my android phone (and stored in my WordPress media library), the previews do not seem to show up ever on Android. Sometimes they'll show up the first time I add the block and photo, but if I leave the editor and come back to the draft, the previews never load. I let my phone sit for 5 minutes plus, and the previews never load. I see them load immediately on iPhone every time. To be clear I see this problem on Android in the Play Store beta build, on gb-mobile current develop, and on this branch, so it is not unique to the change here.
@ceyhun Can you verify if leaving and coming back to an article draft with any video blocks on Android shows any preview for you? This could be out of scope, but then again, it's hard to tell if the update here is breaking anything if Android video blocks are just black screens in the editor before and after the change
|
@cameronvoell I was able to reproduce it just now on Android 14.5, Play Store version choosing |
I was able to reproduce on iOS as well on 14.6, App Store version with choosing I think it's this issue #1151 and I'll add a comment over there. |
Comment looks good over there, thanks for checking and documenting that. This change should be good in the mean time 👍 |
Fixes WordPress/gutenberg#19860
react-native-video PR: wordpress-mobile/react-native-video#6
To test:
PR submission checklist:
RELEASE-NOTES.txt
if necessary.