Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge blocks of different types #213

Merged
merged 5 commits into from
Nov 6, 2018

Conversation

daniloercoli
Copy link
Contributor

@daniloercoli daniloercoli commented Oct 31, 2018

Description:

This PR adds the ability of merging blocks of different types.

Moves #167 forward.

Related PRs:

Gutenberg side: WordPress/gutenberg#11294 )(already merged!)

Testing:

  1. Place the caret at the beginning of the first para block in the demo content.
  2. Press backspace.
  3. Make sure the resulting block is as expected (Heading block) and refreshed properly.

package.json Outdated
@@ -43,7 +43,8 @@
"regenerator-runtime": "^0.12.1",
"remote-redux-devtools": "^0.5.12",
"rungen": "^0.3.2",
"sprintf-js": "^1.1.1"
"sprintf-js": "^1.1.1",
"turbo-combine-reducers": "^1.0.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A fix about this has been merged into master so, feel free to update the PR @daniloercoli

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

…g-mobile into issue/167-merge-blocks-different-types

* 'master' of https://github.com/wordpress-mobile/gutenberg-mobile: (27 commits)
  Point to latest from RecyclerViewList
  Point to latest react-native-aztec
  Adding yarn.lock field for `turbo-combine-reducers`.
  Added turbo-combine-reducers dependency to fix failed builds
  Update subrepo ref to point to master again
  Update subrepo ref
  No need for change of default Jest platform
  Update subrepo ref
  Update subrepo ref
  Fix lint warnings
  Mocking `react-native-gutenberg-bridge` to make iOS tests pass. From: jestjs/jest#2208 (comment)
  rn-gutenberg-bridge: Adding dumb iOS implementation to avoid errors.
  Revert "Update gutenberg subproject ref"
  Add react-native-hr library to add styled line+text elements easily
  Update gutenberg subproject ref
  Match wpandroid's Android API levels
  Remove plugin from Babel to make wpandroid release build work
  Fix wpandroid checkstyle issues
  Remove dep, Matro will find the package automagically
  Fix indentation
  ...

# Conflicts:
#	gutenberg
Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@daniloercoli daniloercoli merged commit c969244 into master Nov 6, 2018
@daniloercoli daniloercoli deleted the issue/167-merge-blocks-different-types branch November 6, 2018 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants